Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] CJK languages not working #2322

Closed
2 tasks done
simba3447 opened this issue Oct 3, 2017 · 9 comments
Closed
2 tasks done

[v2] CJK languages not working #2322

simba3447 opened this issue Oct 3, 2017 · 9 comments
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author
Milestone

Comments

@simba3447
Copy link

simba3447 commented Oct 3, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

I'm using canary version and CJK languages don't work.
CJK file names are replaced with question marks.
And when I type CJK, they are displayed as utf-8 unit code style(This error occurs when I use distributed version, not when I build v2 source and run it.).
I tested for Korean, Chinese, Japanese and All of them didn't work.
I hope this could be fixed 😢
2017-10-03 7 10 47
capture

@Stanzilla Stanzilla mentioned this issue Jan 23, 2018
8 tasks
@chabou
Copy link
Collaborator

chabou commented Jan 24, 2018

Please check your locales and retry with our last canary.

@chabou chabou added this to the 2.0.0 milestone Feb 3, 2018
@chabou chabou added the 👀 Awaiting Response Issue or PR is awaiting a response from the author label Feb 3, 2018
@trainto
Copy link

trainto commented Apr 6, 2018

@chabou
I tried canary.15, but it's still not fixed at all.
I'm on macOS and it's Korean version.
Every file name with Korean characters are dispalyed with question marks like ???????.txt,
and when i try to type any Korean characters, it displays exactly same with attached screenshot above.

@trainto
Copy link

trainto commented Apr 6, 2018

@chabou
I found work-around for this.
I just checked my locale, which is "ko_KR.UTF-8", and set this to env option in .hyper.js like
env: {LANG: 'ko_KR.UTF-8'}

and everything works fine~~~

Maybe it could be made to detect system locale and set it to .hyper.js automatically when the .hyper.js first created.

@Stanzilla
Copy link
Collaborator

Good info about macOS issues with Korean and Japanese: #586 (comment)

@Paalon
Copy link

Paalon commented May 22, 2018

Which version of hyper fixes this behavior?

@ypresto
Copy link

ypresto commented Jun 17, 2018

I still get ???????? by ls for file name with Japanese characters.
I'm using Hyper 2.0.0 (stable).

@chabou
Copy link
Collaborator

chabou commented Jun 17, 2018

@ypresto your specific issue should have been fixed in our last canary. Thanks to #2913

@ypresto
Copy link

ypresto commented Jun 18, 2018

Updated to canary and confirmed it is fixed! Thanks!

chabou pushed a commit that referenced this issue Dec 15, 2018
@ellemedit
Copy link

By default Hyper 2.1.2 on Mojave is not able to input and composition Korean.
Adding env: {LANG: 'ko_KR.UTF-8'} as afore comment fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author
Projects
None yet
Development

No branches or pull requests

7 participants