[test] Use unique error messages in server-source-maps

eps1lon · eps1lon · commit 2684a4667f54 · 2025-05-13T19:38:21.000+02:00
Allows unambigious assertions on CLI output.
Not that interesting for dev but `next build` will
have the logs for all pages in all tests.
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js.map b/test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js.map
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-cause/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-cause/page.js
@@ -1,7 +1,7 @@
 import { connection } from 'next/server'
 
 function logError(cause) {
-  const error = new Error('Boom', { cause })
+  const error = new Error('rsc-error-log-cause', { cause })
   console.error(error)
 }
 
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-custom-name/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-custom-name/page.js
@@ -8,7 +8,7 @@ class NamedError extends Error {
 export default async function Page() {
   await connection()
 
-  console.error(new UnnamedError('Foo'))
-  console.error(new NamedError('Bar'))
+  console.error(new UnnamedError('rsc-error-log-custom-name-Foo'))
+  console.error(new NamedError('rsc-error-log-custom-name-Bar'))
   return null
 }
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-ignore-listed/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-ignore-listed/page.js
@@ -6,7 +6,7 @@ import { runExternal } from 'external-pkg'
 import { runExternalSourceMapped } from 'external-pkg/sourcemapped'
 
 function logError() {
-  const error = new Error('Boom')
+  const error = new Error('rsc-error-log-ignore-listed')
   console.error(error)
 }
 
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log/page.js
@@ -2,7 +2,7 @@ import { someClass } from './styles.module.css'
 import { connection } from 'next/server'
 
 function logError() {
-  const error = new Error('Boom')
+  const error = new Error('rsc-error-log')
   console.error(error)
 }
 
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-error-log-ignore-listed/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-error-log-ignore-listed/page.js
@@ -6,7 +6,7 @@ import { runExternal } from 'external-pkg'
 import { runExternalSourceMapped } from 'external-pkg/sourcemapped'
 
 function logError() {
-  const error = new Error('Boom')
+  const error = new Error('ssr-error-log-ignore-listed')
   console.error(error)
 }
 
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-throw/Thrower.js b/test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-throw/Thrower.js
@@ -1,7 +1,7 @@
 'use client'
 
 function throwError() {
-  throw new Error('Boom')
+  throw new Error('ssr-throw')
 }
 
 export function Thrower() {
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/default/bad-sourcemap/page.js b/test/e2e/app-dir/server-source-maps/fixtures/default/bad-sourcemap/page.js
@@ -5,7 +5,7 @@
 import { connection } from 'next/server'
 
 function logError() {
-  console.error(new Error('Boom!'))
+  console.error(new Error('bad-sourcemap'))
 }
 
 export default async function Page() {
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-error-log/page.js b/test/e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-error-log/page.js
@@ -1,5 +1,5 @@
 function logError() {
-  console.error(new Error('Boom'))
+  console.error(new Error('rsc-error-log'))
 }
 
 export default function Page() {
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-throw/page.js b/test/e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-throw/page.js
@@ -1,5 +1,5 @@
 function throwError() {
-  throw new Error('Boom')
+  throw new Error('rsc-throw')
 }
 
 export default function Page() {
diff --git a/test/e2e/app-dir/server-source-maps/fixtures/edge/app/ssr-throw/page.js b/test/e2e/app-dir/server-source-maps/fixtures/edge/app/ssr-throw/page.js
@@ -1,7 +1,7 @@
 'use client'
 
 function throwError() {
-  throw new Error('Boom')
+  throw new Error('ssr-throw')
 }
 
 export default function Page() {
diff --git a/test/e2e/app-dir/server-source-maps/server-source-maps.test.ts b/test/e2e/app-dir/server-source-maps/server-source-maps.test.ts
@@ -30,15 +30,17 @@ describe('app-dir - server source maps', () => {
 
     if (isNextDev) {
       await retry(() => {
-        expect(next.cliOutput.slice(outputIndex)).toContain('Error: Boom')
+        expect(next.cliOutput.slice(outputIndex)).toContain(
+          'Error: rsc-error-log'
+        )
       })
       expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
-        '\nError: Boom' +
+        '\nError: rsc-error-log' +
           '\n    at logError (app/rsc-error-log/page.js:5:16)' +
           '\n    at Page (app/rsc-error-log/page.js:12:2)' +
           '\n  3 |' +
           '\n  4 | function logError() {' +
-          "\n> 5 |   const error = new Error('Boom')" +
+          "\n> 5 |   const error = new Error('rsc-error-log')" +
           '\n    |                ^' +
           '\n  6 |   console.error(error)' +
           '\n  7 | }' +
@@ -56,17 +58,17 @@ describe('app-dir - server source maps', () => {
 
     if (isNextDev) {
       await retry(() => {
-        expect(next.cliOutput.slice(outputIndex)).toContain('Error: Boom')
+        expect(next.cliOutput.slice(outputIndex)).toContain(
+          'Error: rsc-error-log-cause'
+        )
       })
       expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
-        '\nError: Boom' +
+        '\nError: rsc-error-log-cause' +
           '\n    at logError (app/rsc-error-log-cause/page.js:4:16)' +
-          (isTurbopack
-            ? '\n    at Page (app/rsc-error-log-cause/page.js:12:2)'
-            : '\n    at Page (app/rsc-error-log-cause/page.js:12:2)') +
+          '\n    at Page (app/rsc-error-log-cause/page.js:12:2)' +
           '\n  2 |' +
           '\n  3 | function logError(cause) {' +
-          "\n> 4 |   const error = new Error('Boom', { cause })" +
+          "\n> 4 |   const error = new Error('rsc-error-log-cause', { cause })" +
           '\n    |                ^' +
           '\n  5 |   console.error(error)' +
           '\n  6 | }' +
@@ -93,11 +95,13 @@ describe('app-dir - server source maps', () => {
 
     if (isNextDev) {
       await retry(() => {
-        expect(next.cliOutput.slice(outputIndex)).toContain('Error: Boom')
+        expect(next.cliOutput.slice(outputIndex)).toContain(
+          'Error: ssr-error-log-ignore-listed'
+        )
       })
       expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
         isTurbopack
-          ? '\nError: Boom' +
+          ? '\nError: ssr-error-log-ignore-listed' +
               '\n    at logError (app/ssr-error-log-ignore-listed/page.js:9:16)' +
               '\n    at runWithInternalIgnored (app/ssr-error-log-ignore-listed/page.js:19:12)' +
               '\n    at runWithExternalSourceMapped (app/ssr-error-log-ignore-listed/page.js:18:29)' +
@@ -112,7 +116,7 @@ describe('app-dir - server source maps', () => {
               '\n    at Page (app/ssr-error-log-ignore-listed/page.js:14:14)' +
               '\n   7 |' +
               '\n'
-          : '\nError: Boom' +
+          : '\nError: ssr-error-log-ignore-listed' +
               '\n    at logError (app/ssr-error-log-ignore-listed/page.js:9:16)' +
               '\n    at runWithInternalIgnored (app/ssr-error-log-ignore-listed/page.js:19:12)' +
               // TODO(veil-NDX-910): Webpacks's sourcemap loader drops `ignoreList`
@@ -138,11 +142,11 @@ describe('app-dir - server source maps', () => {
         // TODO(veil-NDX-910): Turbopack's sourcemap loader drops `ignoreList` in browser sourcemaps.
         await expect(browser).toDisplayCollapsedRedbox(`
          {
-           "description": "Boom",
+           "description": "ssr-error-log-ignore-listed",
            "environmentLabel": null,
            "label": "Console Error",
            "source": "app/ssr-error-log-ignore-listed/page.js (9:17) @ logError
-         >  9 |   const error = new Error('Boom')
+         >  9 |   const error = new Error('ssr-error-log-ignore-listed')
               |                 ^",
            "stack": [
              "logError app/ssr-error-log-ignore-listed/page.js (9:17)",
@@ -164,11 +168,11 @@ describe('app-dir - server source maps', () => {
         // TODO(veil): Webpack's sourcemap loader creates an incorrect `sources` entry.
         await expect(browser).toDisplayCollapsedRedbox(`
          {
-           "description": "Boom",
+           "description": "ssr-error-log-ignore-listed",
            "environmentLabel": null,
            "label": "Console Error",
            "source": "app/ssr-error-log-ignore-listed/page.js (9:17) @ logError
-         >  9 |   const error = new Error('Boom')
+         >  9 |   const error = new Error('ssr-error-log-ignore-listed')
               |                 ^",
            "stack": [
              "logError app/ssr-error-log-ignore-listed/page.js (9:17)",
@@ -197,12 +201,12 @@ describe('app-dir - server source maps', () => {
     if (isNextDev) {
       await retry(() => {
         expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
-          'Error: Boom'
+          'Error: rsc-error-log-ignore-listed'
         )
       })
       expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
         isTurbopack
-          ? '\nError: Boom' +
+          ? '\nError: rsc-error-log-ignore-listed' +
               '\n    at logError (app/rsc-error-log-ignore-listed/page.js:9:16)' +
               '\n    at runWithInternalIgnored (app/rsc-error-log-ignore-listed/page.js:21:12)' +
               '\n    at runWithExternalSourceMapped (app/rsc-error-log-ignore-listed/page.js:20:29)' +
@@ -217,7 +221,7 @@ describe('app-dir - server source maps', () => {
               '\n    at Page (app/rsc-error-log-ignore-listed/page.js:16:14)' +
               '\n   7 |' +
               '\n'
-          : '\nError: Boom' +
+          : '\nError: rsc-error-log-ignore-listed' +
               '\n    at logError (app/rsc-error-log-ignore-listed/page.js:9:16)' +
               '\n    at runWithInternalIgnored (app/rsc-error-log-ignore-listed/page.js:21:12)' +
               // TODO(veil): Webpacks's sourcemap loader drops `ignoreList`
@@ -249,17 +253,17 @@ describe('app-dir - server source maps', () => {
 
     if (isNextDev) {
       await retry(() => {
-        expect(next.cliOutput.slice(outputIndex)).toContain('Error: Boom')
+        expect(next.cliOutput.slice(outputIndex)).toContain('Error: ssr-throw')
       })
 
       const cliOutput = stripAnsi(next.cliOutput.slice(outputIndex))
       expect(cliOutput).toContain(
-        '\n ⨯ Error: Boom' +
+        '\n ⨯ Error: ssr-throw' +
           '\n    at throwError (app/ssr-throw/Thrower.js:4:8)' +
           '\n    at Thrower (app/ssr-throw/Thrower.js:8:2)' +
           '\n  2 |' +
           '\n  3 | function throwError() {' +
-          "\n> 4 |   throw new Error('Boom')" +
+          "\n> 4 |   throw new Error('ssr-throw')" +
           '\n    |        ^' +
           '\n  5 | }' +
           '\n  6 |' +
@@ -270,11 +274,11 @@ describe('app-dir - server source maps', () => {
 
       await expect(browser).toDisplayRedbox(`
        {
-         "description": "Boom",
+         "description": "ssr-throw",
          "environmentLabel": null,
          "label": "Runtime Error",
          "source": "app/ssr-throw/Thrower.js (4:9) @ throwError
-       > 4 |   throw new Error('Boom')
+       > 4 |   throw new Error('ssr-throw')
            |         ^",
          "stack": [
            "throwError app/ssr-throw/Thrower.js (4:9)",
@@ -294,14 +298,16 @@ describe('app-dir - server source maps', () => {
 
     await retry(() => {
       expect(next.cliOutput.slice(outputIndex)).toContain(
-        // TODO: isNextDev ? 'UnnamedError: Foo' : '[Error]: Foo'
-        isNextDev ? 'Error: Foo' : 'Error: Foo'
+        // TODO: isNextDev ? 'UnnamedError: rsc-error-log-custom-name-Foo' : '[Error]: rsc-error-log-custom-name-Foo'
+        isNextDev
+          ? 'Error: rsc-error-log-custom-name-Foo'
+          : 'Error: rsc-error-log-custom-name-Foo'
       )
     })
 
     expect(next.cliOutput.slice(outputIndex)).toContain(
-      // TODO: isNextDev ? 'NamedError [MyError]: Bar' : '[MyError]: Bar'
-      isNextDev ? 'Error [MyError]: Bar' : 'Error [MyError]: Bar'
+      // TODO: isNextDev ? 'NamedError [MyError]: rsc-error-log-custom-name-Bar' : '[MyError]: rsc-error-log-custom-name-Bar'
+      isNextDev ? 'Error [MyError]: rsc-error-log-custom-name-Bar' : 'Error [MyError]: rsc-error-log-custom-name-Bar'
     )
   })
 
@@ -311,7 +317,7 @@ describe('app-dir - server source maps', () => {
 
     await retry(() => {
       expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
-        'Error: Boom!'
+        'Error: bad-sourcemap'
       )
     })
 
@@ -320,7 +326,7 @@ describe('app-dir - server source maps', () => {
         expect(normalizeCliOutput(next.cliOutput.slice(outputIndex))).toContain(
           // Node.js is fine with invalid URLs in index maps apparently.
           '' +
-            '\nError: Boom!' +
+            '\nError: bad-sourcemap' +
             '\n    at logError (custom://[badhost]/app/bad-sourcemap/page.js:8:16)' +
             '\n    at Page (custom://[badhost]/app/bad-sourcemap/page.js:13:2)' +
             // TODO: Remove blank line
@@ -333,7 +339,7 @@ describe('app-dir - server source maps', () => {
           // sourcemapping is broken on invalid sources.
           '' +
             `\nwebpack-internal:///(rsc)/./app/bad-sourcemap/page.js: Invalid source map. Only conformant source maps can be used to find the original code. Cause: TypeError [ERR_INVALID_ARG_TYPE]: The "payload" argument must be of type object. Received null` +
-            '\nError: Boom!' +
+            '\nError: bad-sourcemap' +
             '\n    at logError (webpack-internal:///(rsc)/./app/bad-sourcemap/page.js:14:19)' +
             '\n    at Page (webpack-internal:///(rsc)/./app/bad-sourcemap/page.js:18:5)'
         )

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { connection } from 'next/server'`
`2`	`2`
`3`	`3`	`function logError(cause) {`
`4`		`- const error = new Error('Boom', { cause })`
	`4`	`+ const error = new Error('rsc-error-log-cause', { cause })`
`5`	`5`	`console.error(error)`
`6`	`6`	`}`
`7`	`7`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ class NamedError extends Error {`
`8`	`8`	`export default async function Page() {`
`9`	`9`	`await connection()`
`10`	`10`
`11`		`- console.error(new UnnamedError('Foo'))`
`12`		`- console.error(new NamedError('Bar'))`
	`11`	`+ console.error(new UnnamedError('rsc-error-log-custom-name-Foo'))`
	`12`	`+ console.error(new NamedError('rsc-error-log-custom-name-Bar'))`
`13`	`13`	`return null`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ import { runExternal } from 'external-pkg'`
`6`	`6`	`import { runExternalSourceMapped } from 'external-pkg/sourcemapped'`
`7`	`7`
`8`	`8`	`function logError() {`
`9`		`- const error = new Error('Boom')`
	`9`	`+ const error = new Error('rsc-error-log-ignore-listed')`
`10`	`10`	`console.error(error)`
`11`	`11`	`}`
`12`	`12`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { someClass } from './styles.module.css'`
`2`	`2`	`import { connection } from 'next/server'`
`3`	`3`
`4`	`4`	`function logError() {`
`5`		`- const error = new Error('Boom')`
	`5`	`+ const error = new Error('rsc-error-log')`
`6`	`6`	`console.error(error)`
`7`	`7`	`}`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`'use client'`
`2`	`2`
`3`	`3`	`function throwError() {`
`4`		`- throw new Error('Boom')`
	`4`	`+ throw new Error('ssr-throw')`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`export function Thrower() {`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`import { connection } from 'next/server'`
`6`	`6`
`7`	`7`	`function logError() {`
`8`		`- console.error(new Error('Boom!'))`
	`8`	`+ console.error(new Error('bad-sourcemap'))`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`export default async function Page() {`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`function logError() {`
`2`		`- console.error(new Error('Boom'))`
	`2`	`+ console.error(new Error('rsc-error-log'))`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`export default function Page() {`