Turbopack: Fix sizes=any with icon.svg metadata file (#78663)

## What?

The check for the svg extension that exists in the webpack loader was
missing:
https://github.com/vercel/next.js/blob/757542a400945c7709f1338e5619b171304b8d48/packages/next/src/build/webpack/loaders/next-metadata-image-loader.ts#L150

Implemented that.

Fixes PACK-4475
Fixes #78520

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Author: timneutkens

crates/next-core/src/app_page_loader_tree.rs

@@ -268,10 +268,16 @@ impl AppPageLoaderTreeBuilder {
             writeln!(self.loader_tree_code, "{s}  width: {identifier}.width,")?;
             writeln!(self.loader_tree_code, "{s}  height: {identifier}.height,")?;
         } else {
-            writeln!(
-                self.loader_tree_code,
-                "{s}  sizes: `${{{identifier}.width}}x${{{identifier}.height}}`,"
-            )?;
+            let ext = &*path.extension().await?;
+            // For SVGs, skip sizes and use "any" to let it scale automatically based on viewport,
+            // For the images doesn't provide the size properly, use "any" as well.
+            // If the size is presented, use the actual size for the image.
+            let sizes = if ext == "svg" {
+                "any".to_string()
+            } else {
+                format!("${{{identifier}.width}}x${{{identifier}.height}}")
+            };
+            writeln!(self.loader_tree_code, "{s}  sizes: `{sizes}`,")?;
         }
 
         let content_type = get_content_type(path).await?;

crates/next-core/src/next_app/metadata/image.rs

@@ -53,9 +53,22 @@ pub async fn dynamic_image_metadata_source(
 
     let use_numeric_sizes = ty == "twitter" || ty == "openGraph";
     let sizes = if use_numeric_sizes {
-        "data.width = size.width; data.height = size.height;"
+        "data.width = size.width; data.height = size.height;".to_string()
     } else {
-        "data.sizes = size.width + \"x\" + size.height;"
+        // Note: This case seemingly can never happen because this code runs for dynamic metadata
+        // which has e.g. a `.js` or `.ts` extension not `.svg`. Branching code is still here to
+        // match the static implementation
+        //
+        // For SVGs, skip sizes and use "any" to let it scale automatically based on viewport,
+        // For the images doesn't provide the size properly, use "any" as well.
+        // If the size is presented, use the actual size for the image.
+        let sizes = if ext == "svg" {
+            "any"
+        } else {
+            "${size.width}x${size.height}"
+        };
+
+        format!("data.sizes = `{sizes}`;")
     };
 
     let source = Vc::upcast(FileSource::new(path));

test/e2e/app-dir/metadata-svg-icon/app/favicon.ico

@@ -0,0 +1,8 @@
+import { ReactNode } from 'react'
+export default function Root({ children }: { children: ReactNode }) {
+  return (
+    <html>
+      <body>{children}</body>
+    </html>
+  )
+}

test/e2e/app-dir/metadata-svg-icon/app/icon.svg

@@ -0,0 +1,3 @@
+export default function Page() {
+  return <p>hello world</p>
+}

test/e2e/app-dir/metadata-svg-icon/app/layout.tsx

@@ -0,0 +1,13 @@
+import { nextTestSetup } from 'e2e-utils'
+
+describe('metadata-svg-icon', () => {
+  const { next } = nextTestSetup({
+    files: __dirname,
+  })
+
+  it('should have sizes=any for .svg icon', async () => {
+    const $ = await next.render$('/')
+    const icon = $('link[rel="icon"][type="image/svg+xml"]')
+    expect(icon.attr('sizes')).toBe('any')
+  })
+})

test/e2e/app-dir/metadata-svg-icon/app/page.tsx

@@ -0,0 +1,6 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {}
+
+module.exports = nextConfig