Turbopack: clean up some old TODOs (#82364)

I looked through all TODOs if there are any remaining "todo fix this for prod builds"-style comments, but there weren't any. But some of them are outdated now

Author: mischnic

crates/next-api/src/app.rs

@@ -66,7 +66,7 @@ use turbopack_core::{
     },
     output::{OutputAsset, OutputAssets},
     raw_output::RawOutput,
-    reference_type::{CssReferenceSubType, ReferenceType},
+    reference_type::{CommonJsReferenceSubType, CssReferenceSubType, ReferenceType},
     resolve::{origin::PlainResolveOrigin, parse::Request, pattern::Pattern},
     source::Source,
     virtual_output::VirtualOutputAsset,
@@ -852,6 +852,7 @@ impl AppProject {
             Request::parse(Pattern::Constant(rcstr!(
                 "next/dist/client/app-next-turbopack.js"
             ))),
+            CommonJsReferenceSubType::Undefined,
             None,
             false,
         )

crates/next-core/src/next_client/runtime_entry.rs

@@ -5,6 +5,7 @@ use turbopack_core::{
     chunk::{EvaluatableAsset, EvaluatableAssetExt, EvaluatableAssets},
     context::AssetContext,
     module::Module,
+    reference_type::CommonJsReferenceSubType,
     resolve::{origin::PlainResolveOrigin, parse::Request},
     source::Source,
 };
@@ -35,6 +36,7 @@ impl RuntimeEntry {
         let modules = cjs_resolve(
             Vc::upcast(PlainResolveOrigin::new(asset_context, path.clone())),
             *request,
+            CommonJsReferenceSubType::Undefined,
             None,
             false,
         )

turbopack/crates/turbopack-cli-utils/src/runtime_entry.rs

@@ -5,6 +5,7 @@ use turbopack_core::{
     chunk::{EvaluatableAsset, EvaluatableAssetExt, EvaluatableAssets},
     context::AssetContext,
     module::Module,
+    reference_type::CommonJsReferenceSubType,
     resolve::{origin::PlainResolveOrigin, parse::Request},
     source::Source,
 };
@@ -35,6 +36,7 @@ impl RuntimeEntry {
         let modules = cjs_resolve(
             Vc::upcast(PlainResolveOrigin::new(asset_context, path.clone())),
             **request,
+            CommonJsReferenceSubType::Undefined,
             None,
             false,
         )

turbopack/crates/turbopack-core/src/module_graph/mod.rs

@@ -2074,7 +2074,7 @@ pub mod tests {
     impl Asset for MockModule {
         #[turbo_tasks::function]
         fn content(&self) -> Vc<AssetContent> {
-            todo!()
+            panic!("MockModule::content shouldn't be called")
         }
     }
 

turbopack/crates/turbopack-core/src/output.rs

@@ -59,6 +59,3 @@ impl OutputAssets {
 /// A set of [OutputAsset]s
 #[turbo_tasks::value(transparent)]
 pub struct OutputAssetsSet(FxIndexSet<ResolvedVc<Box<dyn OutputAsset>>>);
-
-// TODO All Vc::try_resolve_downcast::<Box<dyn OutputAsset>> calls should be
-// removed

turbopack/crates/turbopack-core/src/source.rs

@@ -17,5 +17,3 @@ pub struct OptionSource(Option<ResolvedVc<Box<dyn Source>>>);
 
 #[turbo_tasks::value(transparent)]
 pub struct Sources(Vec<ResolvedVc<Box<dyn Source>>>);
-
-// TODO All Vc::try_resolve_downcast::<Box<dyn Source>> calls should be removed

turbopack/crates/turbopack-css/src/references/compose.rs

@@ -38,9 +38,7 @@ impl ModuleReference for CssModuleComposeReference {
             *self.origin,
             *self.request,
             CssReferenceSubType::Compose,
-            // TODO: add real issue source, currently impossible because `CssClassName` doesn't
-            // contain the source span
-            // https://docs.rs/swc_css_modules/0.21.16/swc_css_modules/enum.CssClassName.html
+            // TODO: add real issue source, currently impossible
             None,
         )
     }

turbopack/crates/turbopack-ecmascript-plugins/src/transform/emotion.rs

@@ -102,15 +102,12 @@ impl EmotionTransformer {
             enabled: Some(true),
             sourcemap: config.sourcemap,
             label_format: config.label_format.as_deref().map(From::from),
-            auto_label: if let Some(auto_label) = config.auto_label.as_ref() {
-                match auto_label {
-                    EmotionLabelKind::Always => Some(true),
-                    EmotionLabelKind::Never => Some(false),
-                    // [TODO]: this is not correct coerece, need to be fixed
-                    EmotionLabelKind::DevOnly => None,
-                }
-            } else {
-                None
+            auto_label: match config.auto_label.as_ref() {
+                Some(EmotionLabelKind::Always) => Some(true),
+                Some(EmotionLabelKind::Never) => Some(false),
+                // [TODO]: this is not correct (doesn't take current mode into account)
+                Some(EmotionLabelKind::DevOnly) => None,
+                None => None,
             },
             import_map: config.import_map.as_ref().map(|map| {
                 map.iter()

turbopack/crates/turbopack-ecmascript-runtime/src/asset_context.rs

@@ -22,7 +22,8 @@ pub async fn get_runtime_asset_context(
             ),
             ..Default::default()
         },
-        // TODO: Somehow this fails to compile when enabled.
+        // TODO: This fails when enabled, we cannot insert helpers for the runtime code as this
+        // happens after bundling.
         // environment: Some(environment),
         environment: None,
         tree_shaking_mode: Some(TreeShakingMode::ReexportsOnly),

turbopack/crates/turbopack-ecmascript-runtime/src/browser_runtime.rs

@@ -73,7 +73,6 @@ pub async fn get_browser_runtime_code(
             runtime_backend_code.push("browser/runtime/dom/dev-backend-dom.ts");
         }
         (ChunkLoading::Dom, RuntimeType::Production) => {
-            // TODO
             runtime_backend_code.push("browser/runtime/dom/runtime-backend-dom.ts");
         }