Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch octal format #1060

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Switch octal format #1060

merged 1 commit into from
Feb 9, 2017
+1 −1

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Feb 9, 2017

Just learned 0755 === 0o755. Cleaner 👍

@timneutkens timneutkens merged commit 15facf0 into vercel:master Feb 9, 2017
@TooTallNate
Copy link
Member

The 0o755 format is the newer one (as of ES6).

Also the 0755 format doesn't work in strict mode:

$ node --use-strict -e "0755"
[eval]:1
0755
^^^^
SyntaxError: Octal literals are not allowed in strict mode.

@lukeed
Copy link
Contributor Author

lukeed commented Feb 9, 2017

Ah, thanks for the info @TooTallNate! Luckily the "old version" still works in Next.js, for now(?).

@lukeed lukeed deleted the octal-type branch February 9, 2017 21:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeed @TooTallNate @timneutkens