Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): Add react version settings on .eslintrc.json in with-typescript-eslint-jest example #21263

Closed
wants to merge 1 commit into from
Closed

fix(example): Add react version settings on .eslintrc.json in with-typescript-eslint-jest example #21263

wants to merge 1 commit into from

Conversation

queq1890
Copy link
Contributor

@queq1890 queq1890 commented Jan 18, 2021 •
edited
Loading

closes #21162

  • Add react version settings on .eslintrc.json

@ijjk ijjk added the examples Issue was opened via the examples template. label Jan 18, 2021
@queq1890
Copy link
Contributor Author

queq1890 commented Jan 18, 2021 •
edited
Loading

I didn't' notice there's a PR that fixes the issue I mentioned (even in the same diff), so let me close mine. My bad! 🙏
#21163

@queq1890 queq1890 closed this Jan 18, 2021
@queq1890 queq1890 deleted the fix-with-typescript-eslint-jest-example branch January 18, 2021 02:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint warning in the starting repository generated by the with-typescript-eslint-jest example
2 participants
@queq1890 @ijjk