Add note about Yarn 2 support. #21657
Conversation
leerob
requested review from
chibicode,
ijjk,
lfades,
Timer and
timneutkens
as code owners
|
(Thanks!) |
| @@ -41,6 +41,8 @@ npm install next react react-dom | |||
| yarn add next react react-dom | |||
| ``` | |||
|
|
|||
| > **Note**: [Yarn 2](https://yarnpkg.com/getting-started/install) is supported as best-effort within Next.js. For best results, use NPM or Yarn 1. | |||
There was a problem hiding this comment.
Yarn 2 !== Yarn PnP, just like with Yarn 1 you can use both PnP and node_modules so this should really be updated as this isn't accurate. The migration guide explicitly states to start with node_modules then enable PnP once ready
There was a problem hiding this comment.
The issue that sprung this PR was multiple place on GitHub it's "Yarn 2 is supported". By default Yarn 2 will enable PnP. So yes, I agree 100% with your statement, but that's not what in practice will happen when people try to use Yarn 2.
There was a problem hiding this comment.
but that's not what in practice will happen when people try to use Yarn 2.
If people skip the migration guide I'd argue that is their problem and not something that should cause Next.js to advise against Yarn 2
There was a problem hiding this comment.
In essence I agree with you, but that's not reality. Yarn 2 defaults to PnP. There is no call to action to migrate. Next.js just states "it works with Yarn 2", not "You must follow the migration guide".
It's very easy to say that it's other people's problem, but it's equally elitist to do so.
|
I think we should remove this comment, @merceyz has been adding extensive e2e tests for Yarn 2 support and the only issue here was a result of using npm + Yarn for disabling telemetry. I want us to have full Yarn 2 compat, so this message doesn't really make sense. |
|
(I am happy to help with any of these wherever I can. I just have my "help our juniors out"-hat on right now. Feel free to shout out).
No, Yarn PnP doesn't work with browserlist's update either! So even when Next.js is fully compatible, there are still upstream dependencies that are not. |
|
Can you open an issue with |
|
@Timer I previously tracked that down and (luckily) already exists: browserslist/browserslist#577 |
As we saw some confusion with users trying out Yarn 2 and hitting roadblocks in their app. Yarn 2 is supported on a best-effort basis.