Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-used lib files #24625

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Remove un-used lib files #24625

merged 2 commits into from
Apr 30, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 30, 2021

This cleans up lib files that didn't end up getting used and were left over from changes.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented Apr 30, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js rm/unused-files Change
buildDuration 11.5s 11.2s -303ms
buildDurationCached 3.6s 3.5s -148ms
nodeModulesSize 46.6 MB 46.5 MB -126 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js rm/unused-files Change
/ failed reqs 0 0
/ total time (seconds) 1.896 1.891 0
/ avg req/sec 1318.26 1321.82 +3.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.067 1.024 -0.04
/error-in-render avg req/sec 2344.01 2441.08 +97.07
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js rm/unused-files Change
597-HASH.js gzip 13.2 kB 13.2 kB
778-HASH.js gzip 7.12 kB 7.12 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.7 kB 60.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js rm/unused-files Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js rm/unused-files Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js rm/unused-files Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js rm/unused-files Change
index.html gzip 608 B 608 B
link.html gzip 615 B 615 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js rm/unused-files Change
buildDuration 14.2s 14s -280ms
buildDurationCached 5.4s 5.3s -119ms
nodeModulesSize 46.6 MB 46.5 MB -126 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js rm/unused-files Change
597-HASH.js gzip 13.2 kB 13.2 kB
778-HASH.js gzip 7.12 kB 7.12 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.7 kB 60.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js rm/unused-files Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js rm/unused-files Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
css-HASH.js gzip 363 B 363 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 9.52 kB 9.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js rm/unused-files Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js rm/unused-files Change
_error.js 1.35 MB 1.35 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.96 kB 1.96 kB
css.html 2.13 kB 2.13 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.35 MB 1.35 MB
link.js 1.4 MB 1.4 MB ⚠️ +2 B
routerDirect.js 1.4 MB 1.4 MB ⚠️ +2 B
withRouter.js 1.4 MB 1.4 MB
Overall change 6.91 MB 6.91 MB ⚠️ +4 B

Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js rm/unused-files Change
buildDuration 9.4s 9.8s ⚠️ +356ms
buildDurationCached 4s 3.9s -120ms
nodeModulesSize 46.6 MB 46.5 MB -126 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js rm/unused-files Change
/ failed reqs 0 0
/ total time (seconds) 1.99 1.99
/ avg req/sec 1256.5 1256.39 ⚠️ -0.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.075 1.039 -0.04
/error-in-render avg req/sec 2326.1 2405.98 +79.88
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js rm/unused-files Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.19 kB 7.19 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js rm/unused-files Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js rm/unused-files Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.36 kB 9.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js rm/unused-files Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js rm/unused-files Change
index.html gzip 612 B 612 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 1a45160

@ijjk ijjk merged commit 01c15c5 into vercel:canary Apr 30, 2021
@ijjk ijjk deleted the rm/unused-files branch April 30, 2021 00:48
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants