Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ie11 support with webpack 5 #25014

Merged
merged 5 commits into from
May 12, 2021
Merged

Fix ie11 support with webpack 5 #25014

merged 5 commits into from
May 12, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 12, 2021 •
edited
Loading

This fixes ie11 compatibility that broke in #24656 from the polyfills not being loaded first, our existing ie11 test caught this but was failing, this ensures the test is passing again. This also updates the hrefValue optional chaining in the eslint plugin as these files aren't transpiled and related tests were failing in azure

Bug

  • Related issues linked using fixes #number
  • Integration tests added

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review May 12, 2021 01:09
@ijjk
Copy link
Member Author

ijjk commented May 12, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
buildDuration 14s 14.3s ⚠️ +263ms
buildDurationCached 4.7s 4.4s -270ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +146 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.401 2.352 -0.05
/ avg req/sec 1041.25 1062.87 +21.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.278 1.277 0
/error-in-render avg req/sec 1956.88 1957.82 +0.94
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB -23 B
Overall change 31.1 kB 31.1 kB -23 B
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
index.html gzip 559 B 562 B ⚠️ +3 B
link.html gzip 569 B 570 B ⚠️ +1 B
withRouter.html gzip 556 B 558 B ⚠️ +2 B
Overall change 1.68 kB 1.69 kB ⚠️ +6 B

Diffs

Diff for polyfills-HASH.js 
@@ -6570,10 +6570,7 @@
     /******/ var __webpack_exec__ = function(moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
-    /******/ __webpack_require__.O(0, [774, 179], function() {
-      return __webpack_exec__(8838);
-    });
-    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ var __webpack_exports__ = __webpack_exec__(8838);
     /******/ _N_E = __webpack_exports__;
     /******/
   }
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      href="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       as="script"
     />
     <link
@@ -45,10 +45,10 @@
     </script>
     <script
       nomodule=""
-      src="/_next/static/chunks/polyfills-01e9caf46d9a7f038c09.js"
+      src="/_next/static/chunks/polyfills-78f05ed2388e495e7b7b.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      src="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      href="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       as="script"
     />
     <link
@@ -50,10 +50,10 @@
     </script>
     <script
       nomodule=""
-      src="/_next/static/chunks/polyfills-01e9caf46d9a7f038c09.js"
+      src="/_next/static/chunks/polyfills-78f05ed2388e495e7b7b.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      src="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      href="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       as="script"
     />
     <link
@@ -45,10 +45,10 @@
     </script>
     <script
       nomodule=""
-      src="/_next/static/chunks/polyfills-01e9caf46d9a7f038c09.js"
+      src="/_next/static/chunks/polyfills-78f05ed2388e495e7b7b.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-9bc9a5abd5e320fd0072.js"
+      src="/_next/static/chunks/webpack-51bc462d92f786232839.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
buildDuration 17.6s 17.8s ⚠️ +131ms
buildDurationCached 6.7s 6.7s -35ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +146 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB -23 B
Overall change 31.1 kB 31.1 kB -23 B
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ⚠️ +4 B
Overall change 6.9 MB 6.9 MB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
buildDuration 12.2s 12.1s -74ms
buildDurationCached 5.1s 5.1s -42ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +146 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.432 2.39 -0.04
/ avg req/sec 1027.96 1046.17 +18.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.28 1.281 0
/error-in-render avg req/sec 1952.53 1951.21 ⚠️ -1.32
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ie11-webpack5 Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 3a203d3

@kodiakhq kodiakhq bot merged commit 9a0fc42 into vercel:canary May 12, 2021
@ijjk ijjk deleted the fix/ie11-webpack5 branch May 12, 2021 14:49
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Fix ie11 support with webpack 5 (vercel#25014)
4e58314 
This fixes ie11 compatibility that broke in vercel#24656 from the polyfills not being loaded first, our existing ie11 test caught this but was failing, this ensures the test is passing again. This also updates the `hrefValue` optional chaining in the eslint plugin as these files aren't transpiled and related tests were failing in azure 

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens