Ensure custom app regex is correct for Windows

[ijjk]

This ensures the regex used for matching against custom _app files is correct for Windows since it currently only matches forward-slashes correctly. The client-css-nav test has been updated to include global CSS which is run on Windows in CI currently and will help prevent regressing on this.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Fixes: #28579
Fixes: #28632

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
buildDuration	18.3s	16.8s	-1.6s
buildDurationCached	3.9s	3.5s	-466ms
nodeModulesSize	61.7 MB	61.7 MB	⚠️ +94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.369	3.055	-0.31
/ avg req/sec	742.12	818.42	+76.3
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.067	1.887	-0.18
/error-in-render avg req/sec	1209.36	1324.53	+115.17

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	23.3 kB	23.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	67.2 kB	67.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
_buildManifest.js gzip	491 B	491 B	✓
Overall change	491 B	491 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
index.html gzip	540 B	540 B	✓
link.html gzip	553 B	553 B	✓
withRouter.html gzip	534 B	534 B	✓
Overall change	1.63 kB	1.63 kB	✓

---

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
buildDuration	13.5s	13.8s	⚠️ +294ms
buildDurationCached	5.7s	5.5s	-119ms
nodeModulesSize	61.7 MB	61.7 MB	⚠️ +94 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.127	3.01	-0.12
/ avg req/sec	799.41	830.66	+31.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.871	1.874	0
/error-in-render avg req/sec	1336.49	1333.93	⚠️ -2.56

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.7 kB	10.7 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	68.1 kB	68.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/windows-global-css	Change
index.html gzip	584 B	584 B	✓
link.html gzip	597 B	597 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: 4efbae7

[GiancarlosIO]

oh wow, thanks so much @ijjk!!!!!

[ser-veresta]

its seems the bug is still there its not working for me even if i update to 11.1.2

[ijjk]

@ser-veresta can you open a new issue with a repo with minimal reproduction? I'm not able to reproduce this locally on the latest version of Next.js.

[Kyle772]

Thank you for this fix ijjk. Started happening to me randomly and I spent half of today trying to figure out what was causing it. I was ecstatic when I found this new version (we were ONE minor version behind)

Many thanks! Hope you have a killer rest of your week.

[ser-veresta]

@ijjk try running this repo in windows.. this gave me the error. https://github.com/ser-veresta/nextjs