From 856f07d51f5bed89c9b55e9de5ca661efb5dba8c Mon Sep 17 00:00:00 2001 From: Luis Alvarez D Date: Fri, 4 Mar 2022 12:25:43 -0500 Subject: [PATCH 1/2] Update shallow routing caveat --- docs/routing/shallow-routing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/routing/shallow-routing.md b/docs/routing/shallow-routing.md index d1703af6b6e1c..ef9460cb5600b 100644 --- a/docs/routing/shallow-routing.md +++ b/docs/routing/shallow-routing.md @@ -54,7 +54,7 @@ componentDidUpdate(prevProps) { ## Caveats -Shallow routing **only** works for same page URL changes. For example, let's assume we have another page called `pages/about.js`, and you run this: +Shallow routing **only** works for URL changes in the same, current page. For example, let's assume we have another page called `pages/about.js`, and you run this: ```jsx router.push('/?counter=10', '/about?counter=10', { shallow: true }) From bb89874edaf6020584ac33290cebbbd2e3aaf9bc Mon Sep 17 00:00:00 2001 From: Lee Robinson Date: Mon, 7 Mar 2022 17:19:56 -0600 Subject: [PATCH 2/2] Update docs/routing/shallow-routing.md Co-authored-by: Luis Alvarez D. --- docs/routing/shallow-routing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/routing/shallow-routing.md b/docs/routing/shallow-routing.md index ef9460cb5600b..534804bb83694 100644 --- a/docs/routing/shallow-routing.md +++ b/docs/routing/shallow-routing.md @@ -54,7 +54,7 @@ componentDidUpdate(prevProps) { ## Caveats -Shallow routing **only** works for URL changes in the same, current page. For example, let's assume we have another page called `pages/about.js`, and you run this: +Shallow routing **only** works for URL changes in the current page. For example, let's assume we have another page called `pages/about.js`, and you run this: ```jsx router.push('/?counter=10', '/about?counter=10', { shallow: true })