Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typescript to 5.3.3 #62416

Closed
wants to merge 1 commit into from
Closed

chore: upgrade typescript to 5.3.3 #62416

wants to merge 1 commit into from

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 22, 2024

What?

Bump TypeScript of the project to the latest version 5.3.3.

Why?

As introduced in the announcement, TypeScript 5.3 has improved dynamic importing JSON files with the with keyword, replacing the deprecated assert.

This upgrade can potentially improve codes like:

const packageJson = JSON.parse(await fs.readFile(packageJsonPath, 'utf8'))

How?

Since I upgraded TypeScript only and the build succeeded, hope it won't damage any other tests.

@ijjk
Copy link
Member

ijjk commented Feb 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4bdee97

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/typescript@5.3.3 None 0 32 MB typescript-bot

🚮 Removed packages: npm/typescript@5.2.2

View full report↗︎

@styfle
Copy link
Member

styfle commented Feb 22, 2024

This is a duplicate of PR #59494

See the last comment here: #59494 (comment)

@devjiwonchoi
Copy link
Member Author

Roger!

@devjiwonchoi devjiwonchoi deleted the bump-typescript-5.3.3 branch February 22, 2024 20:43
@github-actions github-actions bot added the locked label Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants