Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: avoid unnecessary after wrapper #67463

Merged
merged 2 commits into from
Jul 5, 2024
Merged

refactor: avoid unnecessary after wrapper #67463

merged 2 commits into from
Jul 5, 2024

Commits on Jul 4, 2024

  1. refactor: avoid unnecessary after wrapper 

    I think the wrap function is a leftover from before #66767. We don't
need to return a tuple here, and can just use the `AfterContext`
directly on the call site. This makes its optionality a bit more
obvious, and avoids the noop callback.
    @unstubbable
    unstubbable committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9d15f73 View commit details
    Browse the repository at this point in the history

  2. Rename AfterContextImpl to AfterContext; drop interface

    @unstubbable
    unstubbable committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    926413c View commit details
    Browse the repository at this point in the history