From 44814b91eaf000afc59d24aba4a83a3f09cab9df Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Mon, 9 Sep 2024 19:18:34 +0200 Subject: [PATCH 1/2] test: lock ts type check --- test/production/middleware-typescript/test/index.test.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/production/middleware-typescript/test/index.test.ts b/test/production/middleware-typescript/test/index.test.ts index ea735b20b1d45..7efe22b05019e 100644 --- a/test/production/middleware-typescript/test/index.test.ts +++ b/test/production/middleware-typescript/test/index.test.ts @@ -5,6 +5,11 @@ import { nextTestSetup } from 'e2e-utils' describe('middleware-typescript', () => { const { next } = nextTestSetup({ files: join(__dirname, '../app'), + dependencies: { + // TODO: fix the TS error with the TS 5.6 + // x-ref: https://github.com/vercel/next.js/actions/runs/10777104696/job/29887663970?pr=69784 + typescript: '5.5.4', + }, }) it('should have built and started', async () => { From fec6f2da84a43ce46c3c4a77085ef5f5b4f10ff9 Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Mon, 9 Sep 2024 19:28:04 +0200 Subject: [PATCH 2/2] change all ts default version to 5.5.4 --- test/lib/next-modes/base.ts | 4 +++- test/production/middleware-typescript/test/index.test.ts | 5 ----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/test/lib/next-modes/base.ts b/test/lib/next-modes/base.ts index 561e5229302fc..2797fa63a0cc9 100644 --- a/test/lib/next-modes/base.ts +++ b/test/lib/next-modes/base.ts @@ -173,7 +173,9 @@ export class NextInstance { 'react-dom': reactVersion, '@types/react': 'latest', '@types/react-dom': 'latest', - typescript: 'latest', + // TODO: fix the TS error with the TS 5.6 + // x-ref: https://github.com/vercel/next.js/actions/runs/10777104696/job/29887663970?pr=69784 + typescript: '5.5.4', '@types/node': 'latest', ...this.dependencies, ...this.packageJson?.dependencies, diff --git a/test/production/middleware-typescript/test/index.test.ts b/test/production/middleware-typescript/test/index.test.ts index 7efe22b05019e..ea735b20b1d45 100644 --- a/test/production/middleware-typescript/test/index.test.ts +++ b/test/production/middleware-typescript/test/index.test.ts @@ -5,11 +5,6 @@ import { nextTestSetup } from 'e2e-utils' describe('middleware-typescript', () => { const { next } = nextTestSetup({ files: join(__dirname, '../app'), - dependencies: { - // TODO: fix the TS error with the TS 5.6 - // x-ref: https://github.com/vercel/next.js/actions/runs/10777104696/job/29887663970?pr=69784 - typescript: '5.5.4', - }, }) it('should have built and started', async () => {