Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend support of Pages router to React 18 #70219

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Extend support of Pages router to React 18 #70219

merged 7 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Run tests with all major supported React versions

    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f2b2c80 View commit details
    Browse the repository at this point in the history

  2. Extend support of Pages router to React 18

    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    141b90a View commit details
    Browse the repository at this point in the history

  3. Fall back to react-dom/server.browser in Pages router when React 18… 

    … is installed

React 18 has no `react-dom/server.edge`
    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    82f2a06 View commit details
    Browse the repository at this point in the history

  4. Ignore Webpack warnings for defensive require('react-dom/server.edge') 

    Previously failed `NEXT_TEST_MODE=dev NEXT_TEST_REACT_VERSION="18.3.1" p test test/e2e/app-dir/app-edge/app-edge.test.ts`
    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    87138e3 View commit details
    Browse the repository at this point in the history

  5. Handle hydration errors in React 18 

    This reverts commit 6dfa1c5.
    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3c02bee View commit details
    Browse the repository at this point in the history

  6. fixup! Run tests with all major supported React versions

    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    565abf2 View commit details
    Browse the repository at this point in the history

  7. Avoid bundling react-dom/server.browser in Pages router 

    This was a regression introduced when extending support for Pages router
to React 18.
We have to keep the `try-catch` when the pages runtime is used as an external
(e.g. when the Node.js runtime is used).
However, when bundling, we can alias the module relevant to choosing the
correct `react-dom/server` entrypoint to the one we actually want.
    @eps1lon
    eps1lon committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e490dbe View commit details
    Browse the repository at this point in the history