From 2b0c38cac6d4d6cbb94fbb5321cdb17906a7af2c Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 13:18:10 -0400 Subject: [PATCH 1/7] Test `react(-dom)@canary` Every 12 Hours --- .circleci/config.yml | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index d7621b77c1386..bca708a04e0e0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -41,6 +41,11 @@ commands: - run: name: Linting command: yarn lint + yarn_react_canary: + steps: + - run: + name: Upgrade to React Canary + command: yarn upgrade react@canary react-dom@canary -W # upgrade (vs add) will skip re-building Next.js, which doesn't bundle React internals (so this is OK!) test_all: steps: - run: @@ -114,6 +119,12 @@ jobs: - yarn_install - yarn_lint - *persist_to_workspace + build-react-canary: + executor: node + steps: + - *attach_workspace + - yarn_react_canary + - *persist_to_workspace test: parallelism: 3 executor: node @@ -196,3 +207,19 @@ workflows: only: - master - canary + q12h-react-canary: + triggers: + - schedule: + cron: '0 */12 * * *' + filters: + branches: + only: + - canary + jobs: + - build + - build-react-canary: + requires: + - build + - test: + requires: + - build-react-canary From cfdf5f6a8aac7fb5134de8ea8ee990fc712d7a90 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 13:23:51 -0400 Subject: [PATCH 2/7] Use POSIX syntax --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bca708a04e0e0..5c5d8c599ba3f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -210,7 +210,7 @@ workflows: q12h-react-canary: triggers: - schedule: - cron: '0 */12 * * *' + cron: '0 0,12 * * *' filters: branches: only: From ba5f22f0b0a2255613b8f11af84581722ad2ca7a Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 13:27:32 -0400 Subject: [PATCH 3/7] Test --- .circleci/config.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5c5d8c599ba3f..247d6dec2b3f0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -208,13 +208,6 @@ workflows: - master - canary q12h-react-canary: - triggers: - - schedule: - cron: '0 0,12 * * *' - filters: - branches: - only: - - canary jobs: - build - build-react-canary: From 0b3cde3c4226066309561ca7c9e684070999af32 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 13:28:08 -0400 Subject: [PATCH 4/7] Revert "Test" This reverts commit ba5f22f0b0a2255613b8f11af84581722ad2ca7a. --- .circleci/config.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 247d6dec2b3f0..5c5d8c599ba3f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -208,6 +208,13 @@ workflows: - master - canary q12h-react-canary: + triggers: + - schedule: + cron: '0 0,12 * * *' + filters: + branches: + only: + - canary jobs: - build - build-react-canary: From 768a5eb57fd22f0a54c0a44742492b220e317e7d Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 13:38:10 -0400 Subject: [PATCH 5/7] Print react versions prior to test --- .circleci/config.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5c5d8c599ba3f..1bb2ef8cc4815 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -45,7 +45,12 @@ commands: steps: - run: name: Upgrade to React Canary - command: yarn upgrade react@canary react-dom@canary -W # upgrade (vs add) will skip re-building Next.js, which doesn't bundle React internals (so this is OK!) + command: yarn upgrade react@canary react-dom@canary -W --dev # upgrade (vs add) will skip re-building Next.js, which doesn't bundle React internals (so this is OK!) + yarn_info: + steps: + - run: + name: React Versions + command: yarn why react && yarn why react-dom test_all: steps: - run: @@ -130,6 +135,7 @@ jobs: executor: node steps: - *attach_workspace + - yarn_info - test_all - *store_test_results test-ie11: From c2c284a7a8d6dc9f39c6d16df109da3ed402afdf Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 14:38:27 -0400 Subject: [PATCH 6/7] Revert "Revert "Test"" This reverts commit 0b3cde3c4226066309561ca7c9e684070999af32. --- .circleci/config.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1bb2ef8cc4815..74cdf73ed4929 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -214,13 +214,6 @@ workflows: - master - canary q12h-react-canary: - triggers: - - schedule: - cron: '0 0,12 * * *' - filters: - branches: - only: - - canary jobs: - build - build-react-canary: From 5218607dc9b6eeedfa3b24da3dc432c56a871422 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 21 Oct 2019 14:41:25 -0400 Subject: [PATCH 7/7] Revert "Revert "Revert "Test""" This reverts commit c2c284a7a8d6dc9f39c6d16df109da3ed402afdf. --- .circleci/config.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 74cdf73ed4929..1bb2ef8cc4815 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -214,6 +214,13 @@ workflows: - master - canary q12h-react-canary: + triggers: + - schedule: + cron: '0 0,12 * * *' + filters: + branches: + only: + - canary jobs: - build - build-react-canary: