Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc special case #194

Open
styfle opened this issue May 6, 2021 · 1 comment
Open

Fix grpc special case #194

styfle opened this issue May 6, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@styfle
Copy link
Member

styfle commented May 6, 2021 •
edited
Loading

This started failing yesterday with the latest version of grpc.

https://github.com/vercel/nft/runs/2513068961#step:9:4726

https://github.com/vercel/vercel/runs/2520732314
@styfle styfle added the bug Something isn't working label May 6, 2021
@styfle
Copy link
Member Author

styfle commented May 8, 2021

Turns out grpc is deprecated in favor of @grpc/grpc-js which already works with nft, so supporting a deprecated package isn't necessary.

@Richard87 Richard87 mentioned this issue Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@styfle