Skip to content

Commit

Permalink
chore(release): fix release by avoiding old glibc version (#9464)
Browse files Browse the repository at this point in the history
### Description

#9447 bumped us to
`upload-artifact` to v4 which uses Node 20. Node 20 required a newer
glibc version than was available on our build that targeted AWS's
Lambda2's glibc version. See [this
job](https://github.com/vercel/turborepo/actions/runs/11897321603/job/33151832964#step:12:21)
for an example failure.

Requiring this glibc version isn't necessary for the musl builds since
it uses musl instead of glibc for libc.

I do not think this was intentional to have the musl binary building in
this container as we changed this back when we were cross compiling:
8ca67c3

Future work: This does not fix the `@turbo/repository` release.

### Testing Instructions

Ran test release and x86 msul build now passes:
[job](https://github.com/vercel/turborepo/actions/runs/11917567457/job/33214049836)
  • Loading branch information
chris-olszewski authored Nov 19, 2024
1 parent 7fb5b21 commit 405ccc1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/turborepo-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,9 @@ jobs:
target: "aarch64-apple-darwin"
container-options: "--rm"
- host: ubuntu-latest
container: ubuntu:xenial
container-options: "--platform=linux/amd64 --rm"
container-setup: "apt-get update && apt-get install -y curl musl-tools sudo unzip"
target: "x86_64-unknown-linux-musl"
setup: "apt-get install -y build-essential clang-5.0 lldb-5.0 llvm-5.0-dev libclang-5.0-dev"
setup: "sudo apt-get update && sudo apt-get install -y build-essential clang lldb llvm libclang-dev curl musl-tools sudo unzip"
- host: ubuntu-latest
container-options: "--rm"
target: "aarch64-unknown-linux-musl"
Expand Down

0 comments on commit 405ccc1

Please sign in to comment.