[next] use middleware manifest worker environments #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecklf
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
ztanner,
huozhi,
Ethan-Arrowood and
styfle
as code owners
🦋 Changeset detectedLatest commit: 5a8dccf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…s-with-environment
javivelasco
approved these changes
Apr 8, 2024
ijjk
approved these changes
Apr 8, 2024
This depends on a new Next.js canary release and if we ship the Next.js change first then canary builds are failing because they don't know how to handle the new manifest version? Can do a follow-up PR |
…s-with-environment
…s-with-environment
kodiakhq
bot
deleted the
ecklf/ec-1958-vercelnext-create-edgefunctions-with-environment
branch
Closed
TooTallNate
added a commit
that referenced
this pull request
Apr 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - Add support for edge function environment variables ([#11390](#11390)) - fix flickering during interactive UI rerendering ([#11392](#11392)) - fix `vc ls` message to be `vc projects ls` ([#11400](#11400)) - Updated dependencies \[[`2461b571a`](2461b57)]: - @vercel/next@4.2.0
TooTallNate
added a commit
that referenced
this pull request
Apr 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - Add support for edge function environment variables ([#11390](#11390)) - fix flickering during interactive UI rerendering ([#11392](#11392)) - fix `vc ls` message to be `vc projects ls` ([#11400](#11400)) - Updated dependencies \[[`2461b571a`](2461b57)]: - @vercel/next@4.2.0
huozhi
added a commit
to vercel/next.js
that referenced
this pull request
Apr 11, 2024
### What Bump the edge runtime manifest version and add `environments` property to each route for inlining values for deployment build. ### Why In edge runtime, extract the preview props into edge functions manifest that holding the non-deterministic inline values, then the output build will be more deterministic that helps deployment speed x-ref: vercel/vercel#11390 x-ref: vercel/vercel#11395 Closes NEXT-3012 Closes NEXT-1912
huozhi
added a commit
that referenced
this pull request
May 6, 2024
Rename `environment` property to `env` from middleware manifest added in #11390. Align with vercel/next.js#64521 The `environments` property wasn't working properly before due to unfinished next.js changes, it should work now after testing with next build from vercel/next.js#64521. We change it to a better naming word `env`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to the Next.js builder to pass the per-worker environment emitted from the Next.js middleware manifest to the created
EdgeFunctionresource.