Skip to content

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Nov 7, 2025

It's been seen a few times already that incorrect code assumes that mutations to a step's arguments will be visible to the outer workflow context, which is not the case. Since this is a semantic departure from typical JavaScript runtime behavior, it warrants a section in the documentation explaining the correct approach.

Signed-off-by: Nathan Rajlich <n@n8.io>
.
Signed-off-by: Nathan Rajlich <n@n8.io>
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: d15a60d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 12, 2025 8:26am
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 12, 2025 8:26am
example-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workbench-hono-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workbench-nitro-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workbench-nuxt-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workbench-sveltekit-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workbench-vite-workflow Ready Ready Preview Comment Nov 12, 2025 8:26am
workflow-docs Ready Ready Preview Comment Nov 12, 2025 8:26am

}
```

## Pass-by-Value Semantics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section looks super AI generated and verbose. Can you please summarize it/be terse with the examples and drop the emojis?


By default, steps have a maximum of 3 retry attempts before they fail and propagate the error over to the workflow. Learn more about errors and retrying in the [Errors & Retrying](/docs/foundations/errors-and-retries) page.

<Callout type="warning">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

Copy link
Collaborator

@pranaygp pranaygp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too AI generated. let's be more terse and drop the emojis please

@TooTallNate
Copy link
Member Author

@pranaygp Ok how about now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants