Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSpeakerObserver: fix memory leak and more improvements #942

Merged
merged 6 commits into from
Nov 4, 2022
Merged

ActiveSpeakerObserver: fix memory leak and more improvements #942

merged 6 commits into from
Nov 4, 2022

Commits on Nov 4, 2022

  1. ActiveSpeakerObserver: fix memory leak and more improvements 

    - When deleted, `ActiveSpeakerObserver` must iterate all entries in its `mapProducerSpeakers` and free them. This is because `ActiveSpeakerObserver::RemoveProducer()` **won't** be called for each existing `Producer` if the `ActiveSpeakerObserver` or its parent `Router` are directly closed.

- If `AddProducer()` is called with an already paused `Producer`, consider it (because this can happen).

- Code cleanup such as moving class `static` members to the top, initialize numeric members and so on.

- Use `producerSpeaker` to name values in `this->mapProducerSpeakers` instead of naming them `rtpObserver`.
    @ibc
    ibc committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    fb1c65a View commit details
    Browse the repository at this point in the history

  2. cosmetic

    @ibc
    ibc committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5de84ea View commit details
    Browse the repository at this point in the history

  3. Update worker/include/RTC/ActiveSpeakerObserver.hpp 

    Co-authored-by: José Luis Millán <jmillan@aliax.net>
    @ibc @jmillan
    ibc and jmillan authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1f78b93 View commit details
    Browse the repository at this point in the history

  4. foo

    @ibc
    ibc committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7d19a25 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @ibc
    ibc committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    48c94c9 View commit details
    Browse the repository at this point in the history

  6. Use explicit

    @ibc
    ibc committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3097cbe View commit details
    Browse the repository at this point in the history