Skip to content

Commit

Permalink
Fix transitive dependencies for netty-handler
Browse files Browse the repository at this point in the history
Exclude netty-codec-protobuf and netty-codec-marshalling.
We don't want to depend on those jars, because they depend on protobuf/marshalling jars we do not need.
And then JPMS applications may fail to start with FindException because, for example, JBoss Marshalling is missing.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
  • Loading branch information
tsegismont committed Nov 22, 2024
1 parent 3adac96 commit 496aedc
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,23 @@
<groupId>io.netty</groupId>
<artifactId>netty-codec</artifactId>
<version>${netty.version}</version>
<!-- Make sure we do not depend onto those jars, because they depend on protobuf/marshalling jars we do not need -->
<!-- Make sure we don't depend on those jars, because they depend on protobuf/marshalling jars we do not need -->
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-protobuf</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-marshalling</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
<version>${netty.version}</version>
<!-- Make sure we don't depend on those jars, because they depend on protobuf/marshalling jars we do not need -->
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
Expand All @@ -983,7 +999,6 @@
</exclusion>
</exclusions>
</dependency>


<!-- jackson -->
<dependency>
Expand Down

0 comments on commit 496aedc

Please sign in to comment.