Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config type convert bug for item with default null value #164

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Nicole00
Copy link
Contributor

close #163

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fce806e) 56.15% compared to head (130d40c) 56.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
+ Coverage     56.15%   56.23%   +0.07%     
  Complexity       89       89              
============================================
  Files            18       18              
  Lines          1729     1732       +3     
  Branches        336      337       +1     
============================================
+ Hits            971      974       +3     
  Misses          570      570              
  Partials        188      188              
Files Coverage Δ
...la/com/vesoft/exchange/common/config/Configs.scala 63.95% <52.38%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicole00 Nicole00 merged commit e4bd644 into vesoft-inc:master Oct 13, 2023
1 check passed
@Nicole00 Nicole00 deleted the convert branch October 13, 2023 09:20
Nicole00 added a commit to Nicole00/nebula-exchange that referenced this pull request Nov 16, 2023
Nicole00 added a commit that referenced this pull request Nov 17, 2023
* update version match (#156)

* fix config type convert bug for item with default null value (#164)

* add import status and records count (#162)

* add import status and records count

* update test

* support job parallelism for both tags and edges (#165)

* support to get template config file according to the datasource (#170)

* save the failed request before quit due to tooManyError (#172)

* compute the vertex/edge amount from ngql (#169)

* do not repartition when source dataframe has the same partition number with write partition config (#173)

* add graph address for latency info (#175)

* add graph address for latency info

* add qps log

* update version to 3.6.1
Nicole00 added a commit to Nicole00/nebula-exchange that referenced this pull request Nov 27, 2023
* update version match (vesoft-inc#156)

* fix config type convert bug for item with default null value (vesoft-inc#164)

* add import status and records count (vesoft-inc#162)

* add import status and records count

* update test

* support job parallelism for both tags and edges (vesoft-inc#165)

* support to get template config file according to the datasource (vesoft-inc#170)

* save the failed request before quit due to tooManyError (vesoft-inc#172)

* compute the vertex/edge amount from ngql (vesoft-inc#169)

* do not repartition when source dataframe has the same partition number with write partition config (vesoft-inc#173)

* add graph address for latency info (vesoft-inc#175)

* add graph address for latency info

* add qps log

* update version to 3.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Error casting handling of Null lang.String cannot be cast to scala.runtime.Null$
3 participants