-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS: fix the WithoutAuthentication option #290
Conversation
@haoxins Thanks! |
I need to find a solution to fix the test. https://cloud.google.com/docs/authentication/application-default-credentials?hl=zh-cn#attached-sa |
@haoxins Setting |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 79 79
Lines 3857 3857
=======================================
Hits 3390 3390
Misses 458 458
Partials 9 9
☔ View full report in Codecov by Sentry. |
fixed |
@haoxins Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What problem(s) does this PR solve?
When you run the application in the GCP ENVs, such as GKE or GCE.
The GCS client will try to get credentials underlying the ENVs.
See https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity
Unless the user specifies that, we shouldn't set the
WithoutAuthentication
option.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: