Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook rule for protected cluster #408

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Dec 12, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@MegaByte875 MegaByte875 requested review from veezhang and kqzh December 12, 2023 08:29
@MegaByte875
Copy link
Contributor Author

`kubectl delete nc nebula

Error from server: admission webhook "nebulaclustervalidating.nebula-graph.io" denied the request: metadata.annotations[nebula-graph.io/delete-protection]: Forbidden: protected cluster cannot be deleted`

@MegaByte875
Copy link
Contributor Author

#335

Copy link
Contributor

@kqzh kqzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kqzh kqzh merged commit 552e89d into vesoft-inc:master Dec 12, 2023
1 check passed
@MegaByte875 MegaByte875 deleted the protected_cluster branch December 12, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants