feat: update tag/edge edit page #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxiabuluo
reviewed
Feb 24, 2022
Comment on lines
56
to
66
| } else { | ||
| setLoading(true); | ||
| const res = await createTagOrEdge({ | ||
| gql, | ||
| type: createType | ||
| }); | ||
| setLoading(false); | ||
| if (res.code === 0) { | ||
| message.success(intl.get('schema.createSuccess')); | ||
| history.push(`/schema/${space}/${createType}/edit/${name}`); | ||
| } | ||
| } |
Comment on lines
64
to
68
| onOk: async() => { | ||
| if (properties.length > 0) { | ||
| handlePropertyDelete(properties); | ||
| } | ||
| }, |
Comment on lines
119
to
121
| if (editField && editField.alterType === 'ADD') { | ||
| setList(list.slice(0, list.length - 1)); | ||
| } |
There was a problem hiding this comment.
if (editField?.alterType === 'ADD') {
setList(list.slice(0, - 1));
}| } else { | ||
| setTtlRequired(true); | ||
| handleEditBefore(); | ||
| } |
Comment on lines
88
to
90
| onOk: async() => { | ||
| handleTtlDelete(); | ||
| }, |
There was a problem hiding this comment.
// tiny
onOk: () => handleTtlDelete()
// or
onOk: handleTtlDelete
Comment on lines
141
to
138
| const hasIndex = res.filter(i => i.name === editName).length > 0; | ||
| return hasIndex; |
There was a problem hiding this comment.
return res.some(i => i.name === editName);
huaxiabuluo
reviewed
Feb 24, 2022
Comment on lines
80
to
92
| const infoList = reg.exec(str) || []; | ||
| const properties: IProperty[] = fieldInfo.map(i => ({ | ||
| name: i.Field, | ||
| showType: i.Type, | ||
| type: i.Type.startsWith('fixed_string') ? 'fixed_string' : i.Type, | ||
| allowNull: i.Null === 'YES', | ||
| comment: i.Comment === '_EMPTY_' ? '' : i.Comment, | ||
| value: i.Default === '_EMPTY_' ? '' : convertBigNumberToString(i.Default), | ||
| fixedLength: i.Type.startsWith('fixed_string') | ||
| ? i.Type.replace(/[fixed_string(|)]/g, '') | ||
| : '', | ||
| })) || []; | ||
| const duration = (infoList && infoList[2].split(' = ')[1]) || ''; |
There was a problem hiding this comment.
// const infoList = reg.exec(str) || []
// infoList should be certain Array
const duration = infoList[2]?.split(' = ')[1] || '';
mod: code review
hetao92
added a commit
to hetao92/nebula-studio
that referenced
this pull request
Mar 31, 2022
mod: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.