From f8bf624da1b5135af663de716ba2026599fca9a5 Mon Sep 17 00:00:00 2001 From: CPWstatic <13495049+CPWstatic@users.noreply.github.com> Date: Mon, 7 Mar 2022 11:59:21 +0800 Subject: [PATCH] Address comments. --- src/graph/planner/match/ArgumentFinder.h | 2 +- src/graph/planner/match/LabelIndexSeek.h | 3 +-- src/graph/planner/match/MatchPlanner.h | 2 +- src/graph/planner/match/OrderByClausePlanner.h | 2 +- src/graph/planner/match/PropIndexSeek.h | 2 +- src/graph/planner/match/ReturnClausePlanner.h | 2 +- src/graph/planner/match/ScanSeek.h | 3 +-- src/graph/planner/plan/Query.h | 2 +- 8 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/graph/planner/match/ArgumentFinder.h b/src/graph/planner/match/ArgumentFinder.h index 9afa77c5f56..5df51d189ad 100644 --- a/src/graph/planner/match/ArgumentFinder.h +++ b/src/graph/planner/match/ArgumentFinder.h @@ -10,7 +10,7 @@ namespace nebula { namespace graph { -// ArgumentFinder find if a pattern use a named alias that already declared +// ArgumentFinder finds if a pattern use a named alias that already declared // in former patterns. class ArgumentFinder final : public StartVidFinder { public: diff --git a/src/graph/planner/match/LabelIndexSeek.h b/src/graph/planner/match/LabelIndexSeek.h index 6063adf8a90..24f6b550d23 100644 --- a/src/graph/planner/match/LabelIndexSeek.h +++ b/src/graph/planner/match/LabelIndexSeek.h @@ -11,8 +11,7 @@ namespace nebula { namespace graph { -// The LabelIndexSeek was designed to find if could get the starting vids by tag -// index. +// The LabelIndexSeek finds if a plan could get the starting vids by tag index. class LabelIndexSeek final : public StartVidFinder { public: static std::unique_ptr make() { diff --git a/src/graph/planner/match/MatchPlanner.h b/src/graph/planner/match/MatchPlanner.h index 0823f4f13d3..7ce142dfe6d 100644 --- a/src/graph/planner/match/MatchPlanner.h +++ b/src/graph/planner/match/MatchPlanner.h @@ -11,7 +11,7 @@ namespace nebula { namespace graph { -// MatchPlanner generate plans for Match statement based on AstContext. +// MatchPlanner generates plans for Match statement based on AstContext. class MatchPlanner final : public Planner { public: static std::unique_ptr make() { diff --git a/src/graph/planner/match/OrderByClausePlanner.h b/src/graph/planner/match/OrderByClausePlanner.h index d7091cc8433..fbb892cda53 100644 --- a/src/graph/planner/match/OrderByClausePlanner.h +++ b/src/graph/planner/match/OrderByClausePlanner.h @@ -10,7 +10,7 @@ namespace nebula { namespace graph { -// The OrderByClausePlanner generate plan for order by clause; +// The OrderByClausePlanner generates plan for order by clause; class OrderByClausePlanner final : public CypherClausePlanner { public: OrderByClausePlanner() = default; diff --git a/src/graph/planner/match/PropIndexSeek.h b/src/graph/planner/match/PropIndexSeek.h index 6798e6148e0..821178e1615 100644 --- a/src/graph/planner/match/PropIndexSeek.h +++ b/src/graph/planner/match/PropIndexSeek.h @@ -10,7 +10,7 @@ namespace nebula { namespace graph { -// The PropIndexSeek find if a plan could get starting vids by tag +// The PropIndexSeek finds if a plan could get starting vids by tag // props or edge props index. class PropIndexSeek final : public StartVidFinder { public: diff --git a/src/graph/planner/match/ReturnClausePlanner.h b/src/graph/planner/match/ReturnClausePlanner.h index afd1ea3fd80..e93f741af4b 100644 --- a/src/graph/planner/match/ReturnClausePlanner.h +++ b/src/graph/planner/match/ReturnClausePlanner.h @@ -10,7 +10,7 @@ namespace nebula { namespace graph { -// The ReturnClausePlanner generate plan for return clause. +// The ReturnClausePlanner generates plan for return clause. class ReturnClausePlanner final : public CypherClausePlanner { public: ReturnClausePlanner() = default; diff --git a/src/graph/planner/match/ScanSeek.h b/src/graph/planner/match/ScanSeek.h index 859f871b739..c07243d8a7f 100644 --- a/src/graph/planner/match/ScanSeek.h +++ b/src/graph/planner/match/ScanSeek.h @@ -11,8 +11,7 @@ namespace nebula { namespace graph { -// The ScanSeek find if a plan could get the starting vids in -// filter. +// The ScanSeek finds if a plan could get the starting vids in filter. class ScanSeek final : public StartVidFinder { public: static std::unique_ptr make() { diff --git a/src/graph/planner/plan/Query.h b/src/graph/planner/plan/Query.h index d8ae1e01dd5..71baa40bdfb 100644 --- a/src/graph/planner/plan/Query.h +++ b/src/graph/planner/plan/Query.h @@ -1611,7 +1611,7 @@ class BiLeftJoin final : public BiJoin { void cloneMembers(const BiLeftJoin&); }; -// Lnner join +// Inner join class BiInnerJoin final : public BiJoin { public: static BiInnerJoin* make(QueryContext* qctx,