From fb9411778936cd0756dbb4ee6b916713087345b5 Mon Sep 17 00:00:00 2001
From: Vee Zhang <veezhang@126.com>
Date: Fri, 23 Dec 2022 10:20:26 +0800
Subject: [PATCH] fix: code review

---
 src/kvstore/DiskManager.cpp       | 2 +-
 src/kvstore/RocksEngine.cpp       | 2 +-
 src/kvstore/listener/Listener.cpp | 2 +-
 src/kvstore/raftex/RaftPart.cpp   | 3 ---
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/kvstore/DiskManager.cpp b/src/kvstore/DiskManager.cpp
index d80c3bffd49..efd7cc694a1 100644
--- a/src/kvstore/DiskManager.cpp
+++ b/src/kvstore/DiskManager.cpp
@@ -21,7 +21,7 @@ DiskManager::DiskManager(const std::vector<std::string>& dataPaths,
     paths_.store(paths);
     size_t index = 0;
 
-    // TODO: Add initialize function to avoid using LOG(FATAL) in constructor.
+    // TODO(vee): Add initialize function to avoid using LOG(FATAL) in constructor.
     for (const auto& path : dataPaths) {
       auto absolute = boost::filesystem::absolute(path);
       if (!boost::filesystem::exists(absolute)) {
diff --git a/src/kvstore/RocksEngine.cpp b/src/kvstore/RocksEngine.cpp
index 6bd72d1432c..daf9ba1ff93 100644
--- a/src/kvstore/RocksEngine.cpp
+++ b/src/kvstore/RocksEngine.cpp
@@ -48,7 +48,7 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
   }
   auto path = folly::stringPrintf("%s/data", dataPath_.c_str());
 
-  // TODO: Add initialize function to avoid using LOG(FATAL) in constructor.
+  // TODO(vee): Add initialize function to avoid using LOG(FATAL) in constructor.
   if (FileUtils::fileType(path.c_str()) == FileType::NOTEXIST) {
     if (readonly) {
       LOG(FATAL) << "Path " << path << " not exist";
diff --git a/src/kvstore/listener/Listener.cpp b/src/kvstore/listener/Listener.cpp
index a3f14bb64cf..cea5602b582 100644
--- a/src/kvstore/listener/Listener.cpp
+++ b/src/kvstore/listener/Listener.cpp
@@ -40,7 +40,7 @@ void Listener::start(std::vector<HostAddr>&& peers, bool) {
   std::lock_guard<std::mutex> g(raftLock_);
 
   if (!init()) {
-    // TODO: return bool to avoid using LOG(FATAL)
+    // TODO(vee): return bool to avoid using LOG(FATAL)
     LOG(FATAL) << "Listener init failed";
   }
 
diff --git a/src/kvstore/raftex/RaftPart.cpp b/src/kvstore/raftex/RaftPart.cpp
index 46a6235f59c..d5135260787 100644
--- a/src/kvstore/raftex/RaftPart.cpp
+++ b/src/kvstore/raftex/RaftPart.cpp
@@ -1092,9 +1092,6 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps,
         }
       } else {
         LOG(DFATAL) << idStr_ << "Failed to commit logs";
-        checkAppendLogResult(code);
-        VLOG(3) << idStr_ << "commitLogs failed";
-        iter.commit(code);
         return;
       }
       VLOG(4) << idStr_ << "Leader succeeded in committing the logs " << committedId + 1 << " to "