Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize filter pushdown and fix the bug in TCK tests. #5938

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

Xscaperrr
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

https://discuss.nebula-graph.com.cn/t/topic/15979
进行全量索引扫描时,无法将条件下推至底层IndexScan算子,而利用索引进行前缀搜索时可以。
When performing a full index scan, it is not possible to push down the conditions to the underlying IndexScan operator, whereas it is possible when using the index for prefix searches.

How do you solve it?

修改OptimizerUtils.h中的函数,使其在未找到最佳索引时,仍然会接受filter并写入IndexQueryContext中。
此修改仅能让以and连接的条件下推。
修改MatchSolver.cpp,使其能同样识别OR类型表达式。

在tck测试中,对于未经过转换的字典对象,不再将其key放入keylist,因为该情况后续未使用keylist
直接通过keylist是否为空判断字典是否不存在嵌套

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2024

CLA assistant check
All committers have signed the CLA.

@Salieri-004
Copy link
Contributor

LGTM. Thanks for your help~

@codesigner codesigner enabled auto-merge (squash) September 23, 2024 08:57
@codesigner codesigner merged commit cf9c1c5 into vesoft-inc:master Sep 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants