-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize filter pushdown and fix the bug in TCK tests. #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionaries with only one level of nesting.
Salieri-004
reviewed
Sep 5, 2024
Closed
LGTM. Thanks for your help~ |
Salieri-004
approved these changes
Sep 11, 2024
czpmango
approved these changes
Sep 23, 2024
codesigner
approved these changes
Sep 23, 2024
czpmango
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
https://discuss.nebula-graph.com.cn/t/topic/15979
进行全量索引扫描时,无法将条件下推至底层IndexScan算子,而利用索引进行前缀搜索时可以。
When performing a full index scan, it is not possible to push down the conditions to the underlying IndexScan operator, whereas it is possible when using the index for prefix searches.
How do you solve it?
修改OptimizerUtils.h中的函数,使其在未找到最佳索引时,仍然会接受filter并写入
IndexQueryContext
中。此修改仅能让以and连接的条件下推。
修改MatchSolver.cpp,使其能同样识别OR类型表达式。
在tck测试中,对于未经过转换的字典对象,不再将其key放入keylist,因为该情况后续未使用keylist
直接通过keylist是否为空判断字典是否不存在嵌套
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: