Update workflow action versions, fix docker schedule conditional (#1578)

viamrobotics · Nov 9, 2022 · 5d50577 · 5d50577
1 parent cef1eee
commit 5d50577
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 33 deletions.
diff --git a/.github/workflows/appimage.yml b/.github/workflows/appimage.yml
@@ -49,7 +49,7 @@ jobs:
         make clean-all
 
     - name: Authorize GCP Upload
-      uses: google-github-actions/auth@v0.4.3
+      uses: google-github-actions/auth@v1
       with:
         credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
 
@@ -60,7 +60,7 @@ jobs:
 
     - name: Upload Files (PR)
       if: contains(github.event.pull_request.labels.*.name, 'appimage')
-      uses: google-github-actions/upload-cloud-storage@v0.5.0
+      uses: google-github-actions/upload-cloud-storage@v0.10.4
       with:
         headers: "Cache-Control: no-cache"
         path: 'etc/packaging/appimages/deploy/'
@@ -73,12 +73,12 @@ jobs:
       id: build_test_app
       if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'
       run: |
-        echo "::set-output name=date::`date +%F`"
+        echo "date=`date +%F`" >> $GITHUB_OUTPUT
         make BUILD_CHANNEL="latest" appimage
 
     - name: Upload Files (Testing)
       if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'
-      uses: google-github-actions/upload-cloud-storage@v0.5.0
+      uses: google-github-actions/upload-cloud-storage@v0.10.4
       with:
         headers: "Cache-Control: no-cache"
         path: 'etc/packaging/appimages/deploy/'
@@ -137,12 +137,12 @@ jobs:
 
     steps:
     - name: Authorize GCP
-      uses: google-github-actions/auth@v0.4.3
+      uses: google-github-actions/auth@v1
       with:
         credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
 
     - name: Set up Cloud SDK
-      uses: 'google-github-actions/setup-gcloud@v0'
+      uses: google-github-actions/setup-gcloud@v1
 
     - name: Publish AppImage
       run: |

diff --git a/.github/workflows/appimagecleanup.yml b/.github/workflows/appimagecleanup.yml
@@ -20,12 +20,12 @@ jobs:
 
     steps:
     - name: Authorize GCP
-      uses: google-github-actions/auth@v0.4.3
+      uses: google-github-actions/auth@v1
       with:
         credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
 
     - name: Set up Cloud SDK
-      uses: 'google-github-actions/setup-gcloud@v0'
+      uses: google-github-actions/setup-gcloud@v1
 
     - name: Remove Failed Test AppImages
       run: |

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -34,7 +34,7 @@ jobs:
     timeout-minutes: 30
     steps:
     - name: Login to GitHub Container Registry
-      uses: docker/login-action@v1
+      uses: docker/login-action@v2
       with:
         registry: ghcr.io
         username: ${{ github.actor }}

diff --git a/.github/workflows/pr-labeler.yml b/.github/workflows/pr-labeler.yml
@@ -35,7 +35,7 @@ jobs:
       - name: Add Unsafe PR Comment
         if: |
           steps.is_organization_member.outputs.result == 'false'
-        uses: marocchino/sticky-pull-request-comment@v2.2.0
+        uses: marocchino/sticky-pull-request-comment@v2
         with:
           recreate: true
           message: For security reasons, this PR must be labeled with `safe to test` in order for tests to run.
diff --git a/.github/workflows/pullrequestclose.yml b/.github/workflows/pullrequestclose.yml
@@ -20,12 +20,12 @@ jobs:
 
     steps:
     - name: Authorize GCP
-      uses: google-github-actions/auth@v0.4.3
+      uses: google-github-actions/auth@v1
       with:
         credentials_json: '${{ secrets.GCP_CREDENTIALS }}'
 
     - name: Set up Cloud SDK
-      uses: 'google-github-actions/setup-gcloud@v0'
+      uses: google-github-actions/setup-gcloud@v1
 
     - name: Delete Files
       run: |

diff --git a/.github/workflows/pullrequestcomment.yml b/.github/workflows/pullrequestcomment.yml
@@ -26,15 +26,15 @@ jobs:
         run: cat pr.env >> "${GITHUB_ENV}"
 
       - name: Add Coverage PR Comment
-        uses: marocchino/sticky-pull-request-comment@v2.2.0
+        uses: marocchino/sticky-pull-request-comment@v2
         with:
           number: ${{ env.PR_NUMBER }}
           recreate: true
           path: code-coverage-results.md
 
       - name: Add AppImage Links
         if: ${{ env.APPIMAGE }}
-        uses: marocchino/sticky-pull-request-comment@v2.2.0
+        uses: marocchino/sticky-pull-request-comment@v2
         with:
           recreate: true
           message: |

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -33,7 +33,7 @@ jobs:
 
     steps:
     - name: Check out main branch code
-      if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'
+      if: github.event_name != 'pull_request_target'
       uses: actions/checkout@v3
       with:
         fetch-depth: 2
@@ -114,7 +114,7 @@ jobs:
         rm -rf ./*
 
     - name: Check out main branch code
-      if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'
+      if: github.event_name != 'pull_request_target'
       uses: actions/checkout@v3
       with:
         fetch-depth: 2
@@ -129,28 +129,15 @@ jobs:
     - name: Test
       run: make test-pi
 
-  test_passing:
-    name: All Tests Passing
-    needs: [test_pi, build_and_test]
-    runs-on: [x64, qemu-host]
-    if: always()
-    steps:
-      - name: Check Results
-        run: |
-          echo Test Pi: ${{ needs.test_pi.result }}
-          echo Main Tests: ${{ needs.build_and_test.result }}
-          [ "${{ needs.test_pi.result }}" == "success" ] && \
-          [ "${{ needs.build_and_test.result }}" == "success" ]
-
   test_e2e:
-    name: End-to-End Tests Passing
+    name: Test End-to-End
     runs-on: [x64, qemu-host]
     container:
       image: ghcr.io/viamrobotics/canon:amd64-cache
       options: --platform linux/amd64
     steps:
       - name: Check out main branch code
-        if: github.event_name == 'workflow_dispatch' || github.event_name == 'push'
+        if: github.event_name != 'pull_request_target'
         uses: actions/checkout@v3
         with:
           fetch-depth: 2
@@ -172,7 +159,7 @@ jobs:
           sudo -u testbot bash -lc 'make build-web test-e2e'
 
   test_integration:
-    name: Integration Tests Passing
+    name:  Test SLAM Integration
     runs-on: [x64, qemu-host]
     container:
       image: ghcr.io/viamrobotics/canon:amd64-cache
@@ -200,3 +187,20 @@ jobs:
     - name: Run integration tests
       run: |
         sudo -u testbot bash -lc 'export APPIMAGE_EXTRACT_AND_RUN=1 && make test-integration'
+
+  test_passing:
+    name: All Tests Passing
+    needs: [test_pi, build_and_test, test_e2e, test_integration]
+    runs-on: [x64, qemu-host]
+    if: always()
+    steps:
+      - name: Check Results
+        run: |
+          echo Pi Tests: ${{ needs.test_pi.result }}
+          echo Main Tests: ${{ needs.build_and_test.result }}
+          echo E2E Tests: ${{ needs.test_e2e.result }}
+          echo SLAM Tests: ${{ needs.test_integration.result }}
+          [ "${{ needs.test_pi.result }}" == "success" ] && \
+          [ "${{ needs.build_and_test.result }}" == "success" ] && \
+          [ "${{ needs.test_e2e.result }}" == "success" ] && \
+          [ "${{ needs.test_integration.result }}" == "success" ]
diff --git a/.github/workflows/update_protos.yml b/.github/workflows/update_protos.yml
@@ -14,7 +14,7 @@ jobs:
       image: ghcr.io/viamrobotics/canon:amd64-cache
     steps:
       - uses: actions/checkout@v3
-      - uses: bufbuild/buf-setup-action@v1.8.0
+      - uses: bufbuild/buf-setup-action@v1.9.0
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
       - uses: arduino/setup-protoc@v1