From d919f798fe437b5619224f9e0d6f32555570ffcd Mon Sep 17 00:00:00 2001
From: Maxim Pertsov <maxim@viam.com>
Date: Thu, 19 Jan 2023 10:23:08 -0500
Subject: [PATCH] ignore useless return lint on specific lines

---
 web/frontend/src/components/base.vue         | 8 +++++++-
 web/frontend/src/components/board.vue        | 7 ++++++-
 web/frontend/src/components/motor-detail.vue | 6 +++++-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/web/frontend/src/components/base.vue b/web/frontend/src/components/base.vue
index 96e1d16f8bac..1e75b8ae72da 100644
--- a/web/frontend/src/components/base.vue
+++ b/web/frontend/src/components/base.vue
@@ -1,4 +1,3 @@
-<!-- eslint-disable no-useless-return -->
 <script setup lang="ts">
 
 import { ref, onMounted, onUnmounted } from 'vue';
@@ -86,6 +85,8 @@ const stop = async () => {
     return await bc.stop();
   } catch (error) {
     displayError(error as ServiceError);
+
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -129,6 +130,7 @@ const digestInput = async () => {
     return response;
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -165,6 +167,7 @@ const handleBaseStraight = async (name: string, event: {
       return await bc.setVelocity(linear, angular);
     } catch (error) {
       displayError(error as ServiceError);
+      // eslint-disable-next-line no-useless-return
       return;
     }
   } else {
@@ -172,6 +175,7 @@ const handleBaseStraight = async (name: string, event: {
       return await bc.moveStraight(event.distance, event.speed * event.direction);
     } catch (error) {
       displayError(error as ServiceError);
+      // eslint-disable-next-line no-useless-return
       return;
     }
   }
@@ -184,6 +188,7 @@ const baseRun = async () => {
       return await bc.spin(angle.value * (spinType.value === 'Clockwise' ? -1 : 1), spinSpeed.value);
     } catch (error) {
       displayError(error as ServiceError);
+      // eslint-disable-next-line no-useless-return
       return;
     }
   } else if (movementMode.value === 'Straight') {
@@ -194,6 +199,7 @@ const baseRun = async () => {
       distance: increment.value,
     });
   }
+  // eslint-disable-next-line no-useless-return
   return;
 };
 
diff --git a/web/frontend/src/components/board.vue b/web/frontend/src/components/board.vue
index 8a7b3c817575..29390a758f36 100644
--- a/web/frontend/src/components/board.vue
+++ b/web/frontend/src/components/board.vue
@@ -1,4 +1,3 @@
-<!-- eslint-disable no-useless-return -->
 <script setup lang="ts">
 
 import { toast } from '../lib/toast';
@@ -33,6 +32,7 @@ const getGPIO = async () => {
     return;
   } catch (error) {
     toast.error((error as ServiceError).message);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -44,6 +44,7 @@ const setGPIO = async () => {
     return await bc.setGPIO(setPin, setLevel === 'high');
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -57,6 +58,7 @@ const getPWM = async () => {
     return response;
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -67,6 +69,7 @@ const setPWM = async () => {
     return await bc.setPWM(setPin, Number.parseFloat(pwm) / 100);
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -80,6 +83,7 @@ const getPWMFrequency = async () => {
     return response;
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -90,6 +94,7 @@ const setPWMFrequency = async () => {
     return await bc.setPWMFrequency(setPin, Number.parseFloat(pwmFrequency));
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
diff --git a/web/frontend/src/components/motor-detail.vue b/web/frontend/src/components/motor-detail.vue
index e055ca863cf0..6597cf5f38bd 100644
--- a/web/frontend/src/components/motor-detail.vue
+++ b/web/frontend/src/components/motor-detail.vue
@@ -1,4 +1,3 @@
-<!-- eslint-disable no-useless-return -->
 <script setup lang="ts">
 import { onMounted } from 'vue';
 import { Client, motorApi, MotorClient, ServiceError } from '@viamrobotics/sdk';
@@ -67,6 +66,7 @@ const setPower = async () => {
     return await mc.setPower(powerPct);
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -77,6 +77,7 @@ const goFor = async () => {
     return await mc.goFor(rpm * direction, revolutions);
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -87,6 +88,7 @@ const goTo = async () => {
     return await mc.goTo(rpm, position);
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -112,6 +114,7 @@ const motorStop = async () => {
     return await mc.motorStop();
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 };
@@ -122,6 +125,7 @@ onMounted(async () => {
     properties = await mc.getProperties();
   } catch (error) {
     displayError(error as ServiceError);
+    // eslint-disable-next-line no-useless-return
     return;
   }
 });