-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BME280 temp/humidity/pressure sensor #1413
Add support for BME280 temp/humidity/pressure sensor #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do another pass, but we're not looking to add more components to rdk now. Scope doc for eliot please.
Wasn't making stuff like this part of the point of hack week? So that we can have better support for things, in addition to finding existing bugs? I can make a scope doc, but surely there's some better way to add support for individual common sensor components than writing a document for the CEO first for each one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm good with things like this.
it's not an API change.
Please let vision know about the flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's Get Temperatures and MilliPascals. One tiny div by zero issue I just saw. (It's unlikely)
|
Not sure who else should be on this PR?