-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Component AttrMap Conversion and AttrConfig to gripper models #1444
Merged
randhid
merged 5 commits into
viamrobotics:main
from
randhid:RSDK-738-add-registry-and-models-to-missing-gripper-models
Oct 5, 2022
Merged
Add Component AttrMap Conversion and AttrConfig to gripper models #1444
randhid
merged 5 commits into
viamrobotics:main
from
randhid:RSDK-738-add-registry-and-models-to-missing-gripper-models
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randhid
changed the title
Add registry and AttrConfig to gripper models
Add Component AttrMap COnversion and AttrConfig to gripper models
Oct 5, 2022
randhid
changed the title
Add Component AttrMap COnversion and AttrConfig to gripper models
Add Component AttrMap Conversion and AttrConfig to gripper models
Oct 5, 2022
…8-add-registry-and-models-to-missing-gripper-models
npmenard
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as outdated.
This comment was marked as outdated.
Fahmina
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Soft robotics implementation is wild--- but that's for another day
|
randhid
deleted the
RSDK-738-add-registry-and-models-to-missing-gripper-models
branch
October 5, 2022 22:56
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No config changes except trossen baudrate is now an integer instead of a string that is converted into an integer.