APP-465 Add stop func when toggling off keyboard #1463

anjinai · 2022-10-10T13:47:48Z

20221010_APP-465_Add Stop Func When Toggling Off Keyboard

CLAassistant · 2022-10-10T13:48:30Z

All committers have signed the CLA.

…rd-off-while-its-moving

web/frontend/src/components/keyboard-input.vue

micheal-parks · 2022-10-10T16:27:23Z

web/frontend/src/components/keyboard-input.vue

+const stopBase = () => {
+  const req = new baseApi.StopRequest();
+  req.setName(props.name);
+  window.baseService.stop(req, new grpc.Metadata(), displayError);


One concern I have here: do we know if this gives an error message if the base has already been stopped? If so, then we could end up giving our peeps error messages when they've done nothing wrong. If this is what's going to end up happening I'd recommend not passing errors to displayError.

Based on running this using the fake config, if I toggle the keyboard on, then press the Stop button, and then switch the keyboard toggle to off (which will also kick off the stop command), I see no errors. However, will this be the case when running on a real robot?...I'm not sure :(.

No prob! We can punt on that then.

Confirmed, no errors :)

DTCurrie

✅

…rd-off-while-its-moving

github-actions · 2022-10-13T16:10:02Z

Package	Line Rate	Health
go.viam.com/rdk/components/arm	59%	➖
go.viam.com/rdk/components/arm/universalrobots	12%	❌
go.viam.com/rdk/components/arm/xarm	2%	❌
go.viam.com/rdk/components/arm/yahboom	7%	❌
go.viam.com/rdk/components/audioinput	55%	➖
go.viam.com/rdk/components/base	68%	➖
go.viam.com/rdk/components/base/agilex	62%	➖
go.viam.com/rdk/components/base/boat	41%	❌
go.viam.com/rdk/components/base/wheeled	76%	✅
go.viam.com/rdk/components/board	69%	➖
go.viam.com/rdk/components/board/arduino	10%	❌
go.viam.com/rdk/components/board/commonsysfs	47%	❌
go.viam.com/rdk/components/board/fake	39%	❌
go.viam.com/rdk/components/board/numato	19%	❌
go.viam.com/rdk/components/board/pi	50%	➖
go.viam.com/rdk/components/camera	66%	➖
go.viam.com/rdk/components/camera/fake	67%	➖
go.viam.com/rdk/components/camera/ffmpeg	71%	✅
go.viam.com/rdk/components/camera/transformpipeline	80%	✅
go.viam.com/rdk/components/camera/videosource	58%	➖
go.viam.com/rdk/components/encoder/fake	77%	✅
go.viam.com/rdk/components/gantry	68%	➖
go.viam.com/rdk/components/gantry/multiaxis	84%	✅
go.viam.com/rdk/components/gantry/oneaxis	86%	✅
go.viam.com/rdk/components/generic	85%	✅
go.viam.com/rdk/components/gripper	82%	✅
go.viam.com/rdk/components/input	86%	✅
go.viam.com/rdk/components/input/gpio	87%	✅
go.viam.com/rdk/components/motor	82%	✅
go.viam.com/rdk/components/motor/dmc4000	69%	➖
go.viam.com/rdk/components/motor/fake	60%	➖
go.viam.com/rdk/components/motor/gpio	62%	➖
go.viam.com/rdk/components/motor/gpiostepper	53%	➖
go.viam.com/rdk/components/motor/tmcstepper	65%	➖
go.viam.com/rdk/components/movementsensor	67%	➖
go.viam.com/rdk/components/movementsensor/cameramono	39%	❌
go.viam.com/rdk/components/movementsensor/gpsnmea	37%	❌
go.viam.com/rdk/components/movementsensor/gpsrtk	28%	❌
go.viam.com/rdk/components/posetracker	88%	✅
go.viam.com/rdk/components/sensor	88%	✅
go.viam.com/rdk/components/sensor/ultrasonic	31%	❌
go.viam.com/rdk/components/servo	77%	✅
go.viam.com/rdk/config	77%	✅
go.viam.com/rdk/control	57%	➖
go.viam.com/rdk/data	78%	✅
go.viam.com/rdk/grpc	25%	❌
go.viam.com/rdk/ml	67%	➖
go.viam.com/rdk/ml/inference	70%	✅
go.viam.com/rdk/motionplan	70%	➖
go.viam.com/rdk/operation	93%	✅
go.viam.com/rdk/pointcloud	70%	✅
go.viam.com/rdk/protoutils	62%	➖
go.viam.com/rdk/referenceframe	78%	✅
go.viam.com/rdk/registry	88%	✅
go.viam.com/rdk/resource	85%	✅
go.viam.com/rdk/rimage	78%	✅
go.viam.com/rdk/rimage/depthadapter	94%	✅
go.viam.com/rdk/rimage/transform	73%	✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration	67%	➖
go.viam.com/rdk/robot	93%	✅
go.viam.com/rdk/robot/client	79%	✅
go.viam.com/rdk/robot/framesystem	68%	➖
go.viam.com/rdk/robot/impl	80%	✅
go.viam.com/rdk/robot/server	59%	➖
go.viam.com/rdk/robot/web	61%	➖
go.viam.com/rdk/robot/web/stream	87%	✅
go.viam.com/rdk/services/armremotecontrol	75%	✅
go.viam.com/rdk/services/armremotecontrol/builtin	25%	❌
go.viam.com/rdk/services/baseremotecontrol	75%	✅
go.viam.com/rdk/services/baseremotecontrol/builtin	71%	✅
go.viam.com/rdk/services/datamanager	62%	➖
go.viam.com/rdk/services/datamanager/builtin	81%	✅
go.viam.com/rdk/services/datamanager/datacapture	34%	❌
go.viam.com/rdk/services/datamanager/datasync	70%	➖
go.viam.com/rdk/services/motion	68%	➖
go.viam.com/rdk/services/motion/builtin	89%	✅
go.viam.com/rdk/services/navigation	54%	➖
go.viam.com/rdk/services/sensors	78%	✅
go.viam.com/rdk/services/sensors/builtin	97%	✅
go.viam.com/rdk/services/shell	15%	❌
go.viam.com/rdk/services/slam	86%	✅
go.viam.com/rdk/services/slam/builtin	73%	✅
go.viam.com/rdk/services/vision	82%	✅
go.viam.com/rdk/services/vision/builtin	74%	✅
go.viam.com/rdk/spatialmath	85%	✅
go.viam.com/rdk/subtype	96%	✅
go.viam.com/rdk/utils	71%	✅
go.viam.com/rdk/vision	25%	❌
go.viam.com/rdk/vision/chess	80%	✅
go.viam.com/rdk/vision/delaunay	87%	✅
go.viam.com/rdk/vision/keypoints	92%	✅
go.viam.com/rdk/vision/objectdetection	83%	✅
go.viam.com/rdk/vision/odometry	60%	➖
go.viam.com/rdk/vision/odometry/cmd	0%	❌
go.viam.com/rdk/vision/segmentation	48%	❌
go.viam.com/rdk/web/server	26%	❌
Summary	66% (18930 / 28619)	➖

APP-465 - add stop func when toggling off keyboard

cf5302c

anjinai added 2 commits October 10, 2022 10:27

APP-465 - resolve typeerrors

9faab7f

Merge branch 'main' into APP-465-robot-wont-stop-if-you-toggle-keyboa…

28662ae

…rd-off-while-its-moving

anjinai requested a review from DTCurrie October 10, 2022 15:12

micheal-parks reviewed Oct 10, 2022

View reviewed changes

web/frontend/src/components/keyboard-input.vue Outdated Show resolved Hide resolved

anjinai added 2 commits October 10, 2022 12:24

APP-465 - pass around name less

da4e36d

APP-465 - small change

4695aa2

micheal-parks reviewed Oct 10, 2022

View reviewed changes

anjinai marked this pull request as ready for review October 13, 2022 15:51

DTCurrie approved these changes Oct 13, 2022

View reviewed changes

anjinai added 2 commits October 13, 2022 11:54

Merge branch 'main' into APP-465-robot-wont-stop-if-you-toggle-keyboa…

4517016

…rd-off-while-its-moving

APP-465 - make build lint

b672fb8

anjinai merged commit 227375b into viamrobotics:main Oct 13, 2022

anjinai deleted the APP-465-robot-wont-stop-if-you-toggle-keyboard-off-while-its-moving branch October 13, 2022 16:14

bazile-clyde mentioned this pull request Feb 7, 2023

RSDK 1845 bazile-clyde/rdk#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

APP-465 Add stop func when toggling off keyboard #1463

APP-465 Add stop func when toggling off keyboard #1463

anjinai commented Oct 10, 2022

CLAassistant commented Oct 10, 2022 •

edited

Loading

micheal-parks Oct 10, 2022 •

edited

Loading

anjinai Oct 10, 2022

micheal-parks Oct 10, 2022

anjinai Oct 13, 2022

DTCurrie left a comment

github-actions bot commented Oct 13, 2022

APP-465 Add stop func when toggling off keyboard #1463

APP-465 Add stop func when toggling off keyboard #1463

Conversation

anjinai commented Oct 10, 2022

CLAassistant commented Oct 10, 2022 • edited Loading

micheal-parks Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

anjinai Oct 10, 2022

Choose a reason for hiding this comment

micheal-parks Oct 10, 2022

Choose a reason for hiding this comment

anjinai Oct 13, 2022

Choose a reason for hiding this comment

DTCurrie left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 13, 2022

CLAassistant commented Oct 10, 2022 •

edited

Loading

micheal-parks Oct 10, 2022 •

edited

Loading