-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose fetch camera discovery function to resolve proto conflicts #1478
Merged
DTCurrie
merged 1 commit into
viamrobotics:main
from
DTCurrie:APP-801-discovery-service-fix
Oct 17, 2022
Merged
Expose fetch camera discovery function to resolve proto conflicts #1478
DTCurrie
merged 1 commit into
viamrobotics:main
from
DTCurrie:APP-801-discovery-service-fix
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
approved these changes
Oct 11, 2022
micheal-parks
approved these changes
Oct 11, 2022
@micheal-parks I updated our vite build to clear the output directory on build. Turns out a ton of the asset files were not being referenced anymore, we only seem to need the I then updated how we generate the hashes for chunk files to use the most recent git revision, that way it should be consistent between any build system. |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the
fetchCameraDiscoveries
on therobotApi
here since requests for this call that were constructed inapp
used a different protobuf library which caused conflicts.