App 723 cameras #1485
Merged
App 723 cameras #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrloureed
force-pushed
the
APP-723-cameras
branch
from
eea5d35 to
773b58b
Compare
web/frontend/src/components/base.vue
Outdated
| const selectCameras = ref('') | ||
|
|
||
| const initStreamState = () => { | ||
| for (var value of filterResources(props.resources, 'rdk', 'component', 'camera')) { |
There was a problem hiding this comment.
Suggested change
| for (var value of filterResources(props.resources, 'rdk', 'component', 'camera')) { | |
| for (const value of filterResources(props.resources, 'rdk', 'component', 'camera')) { |
web/frontend/src/main.ts
Outdated
| import '@fontsource/space-mono/400-italic.css'; | ||
| import '@fontsource/space-mono/700.css'; | ||
| import '@fontsource/space-mono/700-italic.css'; | ||
| import '@fontsource/space-mono'; |
There was a problem hiding this comment.
Why did we reduce specificity here?
There was a problem hiding this comment.
Seems like the previous imports would only import the variants needed, just curious what this solved
There was a problem hiding this comment.
I'll add them back. I didn't realize they only loaded on need.
| <head> | ||
| <link rel="icon" type="image/png" href="data:image/png;base64,iVBORw0KGgo=" /> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/APP-723