-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA 498 add labels to geometries in rdk #1491
DATA 498 add labels to geometries in rdk #1491
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It all looks good! Congrats on your first big ticket!
func (b *box) Label() string { | ||
return b.label | ||
if b != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! It still slips my mind that nil
essentially can be typed in Go ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can see issues like this causing bugs down the line. I always forget. One day I'll find a good static analyzer to integrate into our workflow that catches stuff like this for us.
func detectionsToPointClouds( | ||
dets []objectdetection.Detection, | ||
confidenceThresh float64, | ||
func detectionToPointCloud( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this change makes a lot of sense
Part 2! This should complete this ticket. Let me know if I left anything out.