-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP-855 - Use LocationSecrets to validate against all known secrets #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamMagaluk
commented
Oct 27, 2022
- Allow multiple location secrets during validation
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Oct 27, 2022
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
October 27, 2022 20:43
4127fc1
to
b6e11d4
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 27, 2022
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
October 28, 2022 18:48
b6e11d4
to
08bdb26
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 28, 2022
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
October 28, 2022 18:49
08bdb26
to
4743a4c
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 28, 2022
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
October 31, 2022 23:08
4743a4c
to
8110082
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 31, 2022
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
October 31, 2022 23:12
8110082
to
bc5924d
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Oct 31, 2022
- Allow multiple location secrets during validation
AdamMagaluk
force-pushed
the
loc-secrets
branch
from
November 1, 2022 15:28
bc5924d
to
79e9bbf
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 1, 2022
|
cheukt
approved these changes
Nov 1, 2022
edaniels
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.