[DATA-749] Fix SLAM integration test timeout #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
kkufieta
changed the title
viambot
added
safe to test
JohnN193
approved these changes
Nov 16, 2022
| if !orbslam_hangs { | ||
| test.That(t, err, test.ShouldBeNil) | ||
| } else if err != nil { | ||
| t.Skip("Skipping test because orbslam failed to shut down") |
There was a problem hiding this comment.
[nit] log should mention the hang issue
| @@ -293,13 +335,27 @@ func integrationTestHelper(t *testing.T, mode slam.Mode) { | |||
| break | |||
| } | |||
| test.That(t, strings.Contains(line, "Fail to track local map!"), test.ShouldBeFalse) | |||
| if time.Since(start_time_sent_image) > time.Duration(dataInsertionMaxTimeoutMin)*time.Minute { | |||
| orbslam_hangs = true | |||
| t.Log("orbslam hangs") | |||
There was a problem hiding this comment.
[nit] log should be more descriptive, maybe mention exiting data loop?
| @@ -153,13 +159,27 @@ func integrationTestHelper(t *testing.T, mode slam.Mode) { | |||
| break | |||
| } | |||
| test.That(t, strings.Contains(line, "Fail to track local map!"), test.ShouldBeFalse) | |||
| if time.Since(start_time_sent_image) > time.Duration(dataInsertionMaxTimeoutMin)*time.Minute { | |||
| orbslam_hangs = true | |||
| t.Log("orbslam hangs") | |||
There was a problem hiding this comment.
[nit] log should be more descriptive, maybe mention exiting data loop?
ghost
reviewed
Nov 16, 2022
viambot
added
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/DATA-749
Orbslam is known to hang frequently indefinitely, especially when running it with a mono camera. When orbslam hangs, it will cause a timeout and is the most likely suspect for the observed timeout issues mentioned in the ticket.
This PR updates the integration test to make sure adding an image to orbslam does not exceed 3 minutes. If it does, we assume that orbslam hangs and handle it accordingly.