Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-899 import proto methods from typescript-sdk #1601

Merged
merged 24 commits into from
Nov 23, 2022
Merged

RSDK-899 import proto methods from typescript-sdk #1601

merged 24 commits into from
Nov 23, 2022

Conversation

maximpertsov
Copy link
Contributor

@maximpertsov maximpertsov commented Nov 16, 2022 •
edited
Loading

JIRA: https://viam.atlassian.net/browse/RSDK-899

Stop generating JS protobufs and instead import them from our typescript sdk.

Questions:

TODOs

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 17, 2022
This was referenced Nov 17, 2022
Closed
Merged
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 22, 2022
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 22, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 22, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 22, 2022
@maximpertsov maximpertsov marked this pull request as ready for review November 22, 2022 23:34
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Nov 22, 2022
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 22, 2022
micheal-parks
micheal-parks approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@micheal-parks micheal-parks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@maximpertsov maximpertsov changed the title RSDK-875 import proto methods from typescript-sdk RSDK-899 import proto methods from typescript-sdk Nov 23, 2022
edaniels
edaniels reviewed Nov 23, 2022
View reviewed changes
Makefile
@@ -41,16 +42,6 @@ tool-install:
gotest.tools/gotestsum \
github.com/rhysd/actionlint/cmd/actionlint

buf: buf-web

buf-web: tool-install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to self, will need to add sessions proto to sdk instead of using buf here

edaniels
edaniels approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DTCurrie
DTCurrie reviewed Nov 23, 2022
View reviewed changes
Makefile Outdated
@@ -21,7 +20,9 @@ build: build-web build-go
build-go:
go build $(GO_BUILD_TAGS) ./...

build-web: buf-web
build-web:
npm ci --audit=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to install/maintain any npm packages at the root level of the project? That single dependency was for how we previously generated buf stuff.

I imagine we can delete the package.json file at the root and just keep the one in web/frontend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great call -- yes the top-level dependency is only for generating protobufs, which this PR removes

DTCurrie
DTCurrie approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ just a question about dependencies

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 23, 2022
@maximpertsov maximpertsov force-pushed the RSDK-875-migrate-rdk-proto-methods-into-ts-sdk branch from 02f33c5 to dba79ac Compare November 23, 2022 20:28
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 23, 2022
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 58% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 13% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% +0.34% ➖
go.viam.com/rdk/components/base 68% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 76% 0.00% ✅
go.viam.com/rdk/components/board 69% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 47% 0.00% ❌
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 65% 0.00% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 77% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 80% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 55% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 77% 0.00% ✅
go.viam.com/rdk/components/gantry 68% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 84% 0.00% ✅
go.viam.com/rdk/components/gripper 81% 0.00% ✅
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/gpio 83% 0.00% ✅
go.viam.com/rdk/components/motor 82% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 57% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 63% -0.43% ➖
go.viam.com/rdk/components/motor/gpiostepper 56% -0.59% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 76% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 40% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 87% 0.00% ✅
go.viam.com/rdk/components/sensor 87% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% 0.00% ❌
go.viam.com/rdk/components/servo 79% 0.00% ✅
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 76% +0.08% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/motionplan 71% 0.00% ✅
go.viam.com/rdk/operation 81% 0.00% ✅
go.viam.com/rdk/pointcloud 71% -0.09% ✅
go.viam.com/rdk/protoutils 62% 0.00% ➖
go.viam.com/rdk/referenceframe 78% 0.00% ✅
go.viam.com/rdk/registry 88% 0.00% ✅
go.viam.com/rdk/resource 85% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 93% 0.00% ✅
go.viam.com/rdk/robot/client 81% 0.00% ✅
go.viam.com/rdk/robot/framesystem 68% 0.00% ➖
go.viam.com/rdk/robot/impl 80% 0.00% ✅
go.viam.com/rdk/robot/server 58% -0.97% ➖
go.viam.com/rdk/robot/web 60% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 25% 0.00% ❌
go.viam.com/rdk/services/baseremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 66% 0.00% ➖
go.viam.com/rdk/services/datamanager 66% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 80% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 21% 0.00% ❌
go.viam.com/rdk/services/datamanager/datasync 72% 0.00% ✅
go.viam.com/rdk/services/motion 68% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 89% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 78% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 14% 0.00% ❌
go.viam.com/rdk/services/slam 85% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 72% 0.00% ✅
go.viam.com/rdk/services/vision 80% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/spatialmath 86% 0.00% ✅
go.viam.com/rdk/subtype 96% 0.00% ✅
go.viam.com/rdk/utils 71% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (19540 / 29517) -0.01% ➖

@maximpertsov maximpertsov merged commit 9ab03b5 into viamrobotics:main Nov 23, 2022
@maximpertsov maximpertsov deleted the RSDK-875-migrate-rdk-proto-methods-into-ts-sdk branch November 23, 2022 20:48
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheal-parks micheal-parks micheal-parks approved these changes

@DTCurrie DTCurrie DTCurrie approved these changes

@edaniels edaniels edaniels approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximpertsov @edaniels @DTCurrie @micheal-parks @viambot