fix: model name validation during proto conversions #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamMagaluk
commented
Dec 19, 2022
viambot
added
the
safe to test
Otterverse
approved these changes
Dec 19, 2022
Related to RSDK-1267 but allows for empty model names in the proto conversions. The ultimitly will be validated in by the config system and either result in partial or full failures of the robot depending on the config.
AdamMagaluk
force-pushed
the
model-config
branch
from
c046d31 to
3bec855
Compare
viambot
added
safe to test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to RSDK-1267 but allows for empty model names in the proto conversions. The ultimately will be validated in by the config system and either result in partial or full failures of the robot depending on the config.