RSDK-577 - allow appimage in PR to ignore test results #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
commented
Dec 23, 2022
| @@ -5,7 +5,6 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
we aren't using this
There was a problem hiding this comment.
[opt] I believe I put this in there originally because "why not?" Made for easier testing if/when needed. Fine with removal though.
viambot
added
safe to test
|
This was AWFUL to test |
|
Otterverse
approved these changes
Dec 24, 2022
| @@ -5,7 +5,6 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
[opt] I believe I put this in there originally because "why not?" Made for easier testing if/when needed. Fine with removal though.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
appimage-ignore-testslabel that will still build an image despite test results (basically always) and can be used in conjunction withappimagealthough it's pointless.This additionally cleans up the logic in our PR workflow such that:
testwhen we receive thesafe to testlabel (this happens per commit) or theappimagelabel (needed for when the label is added after tests run since it's difficult to have a workflow look at a past action run's results; without it, the test job is always skipped)slam_integration_testwhen we receive thesafe to test labelappimageruns conditionally based on test success as expectedappimage-ignore-testsruns conditionally on the same label and does not wait for tests