Add power to base and style #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
|
Tested and works as expected. :) |
viambot
added
safe to test
| @@ -92,19 +94,19 @@ const digestInput = () => { | |||
| for (const item of pressed) { | |||
| switch (item) { | |||
| case Keymap.FORWARD: { | |||
| linearValue += 1; | |||
| linearValue += Number(0.01 * power); | |||
There was a problem hiding this comment.
Suggested change
| linearValue += Number(0.01 * power); | |
| linearValue += Number.parseFloat(0.01 * power); |
There was a problem hiding this comment.
Also, just noticing, why do we need casting here at all? both power and 0.01 are numbers
There was a problem hiding this comment.
I was just limiting the number of decimal places but we don't have to.
| @pointerup="handlePointerUp(key)" | ||
| @pointerleave="handlePointerUp(key)" | ||
| > | ||
| {{ key.toUpperCase() }} |
There was a problem hiding this comment.
should we use text-transform: uppercase instead?
micheal-parks
approved these changes
Jan 17, 2023
viambot
added
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a power slider to the base card, rather than always using 100% power.
RSDK-938