Log that I2C and digital interrupts are not implemented on commonsysfs boards #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
thegreatco
approved these changes
Jan 19, 2023
penguinland
added a commit
that referenced
this pull request
Jan 20, 2023
Sorry about this! We want to log when you try using the unimplemented parts, but not when you're just checking their statuses. So, remove half of #1786. This time, we're going to actually try it out on a robot before merging. Thanks to Pete G and Matt D for pointing out the problem.
Closed
randhid
pushed a commit
to randhid/rdk
that referenced
this pull request
Feb 25, 2023
…s boards (viamrobotics#1786) There have been too many recent frustrating bugs where the eventual cause was traced down to this stuff just not being implemented, and there ought to be an easier way to figure that out.
randhid
pushed a commit
to randhid/rdk
that referenced
this pull request
Feb 25, 2023
Sorry about this! We want to log when you try using the unimplemented parts, but not when you're just checking their statuses. So, remove half of viamrobotics#1786. This time, we're going to actually try it out on a robot before merging. Thanks to Pete G and Matt D for pointing out the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been too many recent frustrating bugs where the eventual cause was traced down to this stuff just not being implemented, and there ought to be an easier way to figure that out.