-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Steering #5191
Merged
Merged
Content Steering #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
feature/content-steering
branch
3 times, most recently
from
January 27, 2023 23:10
a0ddbc0
to
d151621
Compare
5 tasks
robwalch
force-pushed
the
feature/content-steering
branch
4 times, most recently
from
February 1, 2023 00:28
3779c7a
to
9cbb91f
Compare
robwalch
force-pushed
the
feature/content-steering
branch
2 times, most recently
from
February 10, 2023 00:51
b2d51ca
to
05b8a59
Compare
robwalch
force-pushed
the
feature/content-steering
branch
2 times, most recently
from
February 14, 2023 03:00
510f954
to
cc87b72
Compare
robwalch
force-pushed
the
feature/content-steering
branch
2 times, most recently
from
February 15, 2023 18:55
49a3da3
to
3e578db
Compare
Optimize MANIFEST_PARSED level filtering Optimize Media Playlist check
… (unless building without Content Steering support) Store and return seperate LevelAttributes per Fallback Stream URL Align Level audio and text group ids with Fallback Stream URLs (Level._urlId)
…ch when attributes do not change
…title tracks update as well
robwalch
force-pushed
the
feature/content-steering
branch
from
February 15, 2023 19:02
3e578db
to
815f197
Compare
robwalch
force-pushed
the
feature/content-steering
branch
from
February 15, 2023 22:12
815f197
to
626d474
Compare
robwalch
added a commit
that referenced
this pull request
Feb 21, 2023
robwalch
added a commit
that referenced
this pull request
Feb 21, 2023
robwalch
added a commit
that referenced
this pull request
Feb 22, 2023
robwalch
added a commit
that referenced
this pull request
Feb 22, 2023
robwalch
added a commit
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add support for HLS Content Steering. This includes Steering Manifest loading and refresh, as well as Pathway grouping, selection and Pathway Cloning.
Support for legacy redundant streams is maintained and covered by new tests. The HLS.js light build options remove the Content Steering Controller from the light build. The light build treats the multiple Pathways as redundant levels so long as they have variants with matching quality attributes (same as previous releases without Content Steering/PATHWAY-ID support).
The advantage of using a Steering Manifest is that it allows for more dynamic redundancy and URL/host switching, controlled remotely.
With these changes the player will always switch to the Steering Manifest's highest priority Pathway regardless of errors encounters. A followup PR will address Pathway error penalties and switching Pathways on error.
Resolves issues:
Addresses a majority of #5074
Pathway penalty will be addressed in a follow up PR (#5241):
Checklist