Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix issue #810, seekbar doesn't go crazy when cursor out #917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pyrextor
Copy link

Fix issue #810, seekbar doesn't go crazy when cursor is sliding the
seekbar and gets out of the player. Instead getting offsetX, now get the
cursor x coordinate and calculates its position relative to the
scrub-bar to calculate the correct position.

BREAKING CHANGE: 🧨 none

Closes: #810

Description

Please explain the changes you made here. Commit your changes with npm run commit instead of git commit.

Specify if it's a fix, feature or breaking change to update the version on NPM.

Thank you!

Checklist

Please, check that you have been followed next steps:

  • I've read the (contributing)[https://github.com/videogular/videogular2/blob/master/CONTRIBUTING.md] guidelines
  • Code compiles correctly (run npm start)
  • Created tests (if necessary)
  • All tests passing (run npm test)
  • Extended the README / documentation (if necessary)

… out

Fix issue videogular#810, seekbar doesn't go crazy when cursor is sliding the
seekbar and gets out of the player. Instead getting offsetX, now get the
cursor x coordinate and calculates its position relative to the
scrub-bar to calculate the correct position.

BREAKING CHANGE: 🧨 none

✅ Closes: videogular#810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seekbar goes crazy when out of width
1 participant