Prevent Ink from altering the accessibility tree #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendered inside a `<button>`, canvas element produces an unintended side-effect in Chrome, changing the announced role of the button to "button, group". Adding `aria-hidden="true"` effectively hides the canvas element from assistive software such as screen readers, so the role of the button is correctly announced as just "button".
greypants
approved these changes
Sep 13, 2022
nhunzaker
approved these changes
Sep 13, 2022
cwmanning
approved these changes
Sep 15, 2022
|
👍 published in |
|
@cwmanning I've just realized that even though the changes are merged and 6.5.3 is published, see https://unpkg.com/react-ink@6.5.2/dist/ink.js, https://unpkg.com/react-ink@6.5.3/dist/ink.js |
|
Sorry for the mix up! Published as 6.5.4. Confirmed the addition is now in |
|
Thank you @cwmanning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendered inside a
<button>, canvas element produces an unintended side-effect in Chrome, changing the announced role of the button to "button, group". Addingaria-hidden="true"effectively hides the canvas element from assistive software such as screen readers, so the role of the button is correctly announced as just "button".