Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redundant observe with through #271

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jun 7, 2021

For some reason, using observe could cause some "stream already closed" issues when attaching input to a process (e.g. nix eval '(import /dev/stdin)').

@vigoo vigoo merged commit f1fe040 into vigoo:master Jun 7, 2021
@vigoo
Copy link
Owner

vigoo commented Jun 7, 2021

Interesting. Thanks for the fix!

@kubukoz kubukoz deleted the fs2-observe branch June 7, 2021 14:52
@kubukoz
Copy link
Contributor Author

kubukoz commented Jun 7, 2021

Thanks for the quick release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants