Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellation in fs2 3 #410

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

RafalSumislawski
Copy link
Contributor

This fixes #409 for fs2-3. The fix is trivial in this case because CE3 provides interruptibleMany. At the moment I don't know how to fix it for other variants of the library.

I also reproduced the issue using an existing test (it used to pass because cancel was called fast, before the uninterruptible effect started executing) and added a second similar test that checks specifically terminating the sub-process by releasing the Resource.

@vigoo
Copy link
Owner

vigoo commented Oct 16, 2022

Thank you! I will check the other variants.

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 84% // Head: 84% // Decreases project coverage by -0% ⚠️

Coverage data is based on head (e60d340) compared to base (3d803d8).
Patch coverage: 100% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #410   +/-   ##
=====================================
- Coverage      84%    84%   -1%     
=====================================
  Files          14     14           
  Lines         652    652           
  Branches        6      5    -1     
=====================================
- Hits          550    549    -1     
- Misses        102    103    +1     
Impacted Files Coverage Δ
.../src/main/scala/io/github/vigoo/prox/ProxFS2.scala 90% <100%> (ø)
.../src/main/scala/io/github/vigoo/prox/ProxFS2.scala 88% <0%> (-3%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigoo vigoo merged commit 835261e into vigoo:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing the Process#start Resource never terminates
2 participants