Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking if node is executable #28

Closed
conbrad opened this issue May 21, 2016 · 2 comments
Closed

Checking if node is executable #28

conbrad opened this issue May 21, 2016 · 2 comments
Assignees
Milestone

Comments

@conbrad
Copy link

conbrad commented May 21, 2016

The vimrc file checks if it can execute node js on line 42:

if !executable('node') || !executable('npm')

node is executed by issuing nodejs by default though, the check should be

if !executable('nodejs') || !executable('npm')

@krampstudio
Copy link
Collaborator

On which OS ? How did you install node ? I think it depends on the way you've installed it :

  • using nvm or from the sources you'll have only the node binary
  • using the debian's nodejs package you'll get the nodejs binary in addition to node
  • using the nodesource repo I think there's only the node binary

Is it a problem ? If yes I can check for at least one.

@conbrad
Copy link
Author

conbrad commented May 25, 2016

I'm on Lubuntu, which I believe is based off Ubuntu Trusty.

I installed nodejs via debian package or though npm (cannot remember) but there was only nodejs installed not node.

It's not a huge issue, but an extra check will cause less friction for new users.

@krampstudio krampstudio self-assigned this Jun 8, 2016
@krampstudio krampstudio added this to the 1.2.0 milestone Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants